Fix xattr locking #3251
Merged
Fix xattr locking #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduffeck
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
butonic
approved these changes
Sep 20, 2022
dragotin
reviewed
Sep 20, 2022
| @@ -191,17 +191,42 @@ func CopyMetadata(src, target string, filter func(attributeName string) bool) (e | |||
| // Set an extended attribute key to the given value | |||
| // No file locking is involved here as writing a single xattr is | |||
There was a problem hiding this comment.
This comment should be corrected.
dragotin
approved these changes
Sep 20, 2022
| } | ||
| }() | ||
|
|
||
| return xattr.Set(filePath, key, []byte(val)) | ||
| } | ||
|
|
||
| // Remove an extended attribute key | ||
| // No file locking is involved here as writing a single xattr is |
73 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential race condition when listing xattrs of nodes in concurrency situations.