Fix public link resharing #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
|
hm, shouldn't the public link share manager prevent elevating permissions? With this approach you are just shadowing a broken implementation, aren't you? |
|
@butonic I sticked to same implementation as for normal shares. Permissions are checked within the ocs handler. As of now the share manager doesn't care about permissions. |
|
YOLO 😞 |
butonic
approved these changes
Jul 1, 2022
kobergj
added a commit
that referenced
this pull request
Jul 7, 2022
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
added a commit
to kobergj/reva
that referenced
this pull request
Jul 11, 2022
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
added a commit
to kobergj/reva
that referenced
this pull request
Jul 14, 2022
This reverts commit f2b7f3f.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here owncloud/ocis#3881 or here owncloud/ocis#4061
Basically privilege escalation was possible through public links and resharing