More dav unit tests #3461
Merged
More dav unit tests #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
more-dav-unit-tests
branch
2 times, most recently
from
a7d20b1
to
85d34f4
Compare
…ror cases Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
more-dav-unit-tests
branch
from
c36e79e
to
c722cfa
Compare
aduffeck
reviewed
Nov 15, 2022
aduffeck
requested changes
Nov 15, 2022
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
|
@butonic could you add to master as well? |
|
😍 lgtm |
aduffeck
approved these changes
Nov 15, 2022
|
@labkode we started refactoring the error handling, the added tests make use of the error returned by the handlers ... we also moved to ginkgo/v2 ... urgh ... so I cannot even just add the test because they make use of DescribeTable which is only in ginkgo v2 ... most of these cases are covered by the acceptance tests, we just want to develop unit tests to improve the coverage and then refactor the handlers further. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brings ocdav coverage to 16.8%