decomposedfs: shard nodes per space #2554

butonic · 2022-02-16T15:49:35Z

This changes the decomposedfs layout on disk and

shards the nodes per space
distributes the nodes over multiple directories to keep folder sizes manageable
introduce subfolders for spacetypes/{type}/{spaceid}
introduce supfolders for blobstorage -> separate PR
migrate old nodes folder
migrate old spaces/(personal|share|project|metadata|...) links? just recreate?

update-docs · 2022-02-16T15:49:38Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

lgtm-com · 2022-02-16T16:11:11Z

This pull request introduces 2 alerts and fixes 2 when merging e60fb6b into d6ecfe6 - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

micbar · 2022-02-16T18:53:52Z

this needs a rebase.

micbar · 2022-02-16T19:22:45Z

pkg/storage/utils/decomposedfs/lookup.go

-	target, err := os.Readlink(matches[0])
-	if err != nil {
-		appctx.GetLogger(ctx).Error().Err(err).Str("match", matches[0]).Msg("could not read link, skipping")
+func Pathify(id string, depth, width int) string {


two Pathify() functions? one on the lookup, one on the tree?

lgtm-com · 2022-02-16T20:11:53Z

This pull request introduces 2 alerts and fixes 2 when merging 7498a59 into a6eec6a - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-16T21:59:01Z

This pull request introduces 2 alerts and fixes 2 when merging dc13136 into 67204fe - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-16T22:27:15Z

This pull request introduces 2 alerts and fixes 2 when merging 043f338 into 67204fe - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-17T07:42:27Z

This pull request introduces 2 alerts and fixes 2 when merging 5713bc0 into 67204fe - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-17T09:43:52Z

This pull request introduces 2 alerts and fixes 2 when merging 63c0dc9 into 67204fe - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-17T11:25:29Z

This pull request introduces 2 alerts and fixes 2 when merging 0b98a42 into 67204fe - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

labkode · 2022-02-17T15:42:43Z

@butonic I suggest you to add constant with the width size rather than calling the numeric argument on each call.
A width of 3 is plenty of room, the nodei-d is a uniform distribution or based on something like username/filename?

lgtm-com · 2022-02-17T15:53:43Z

This pull request introduces 2 alerts and fixes 2 when merging 7d2b818 into 67204fe - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

butonic · 2022-02-17T16:14:19Z

@butonic I suggest you to add constant with the width size rather than calling the numeric argument on each call. A width of 3 is plenty of room, the nodei-d is a uniform distribution or based on something like username/filename?

good points:

I initially wanted to make the depth and width configurable, but it has quite an effect on symlink parent segments and I will postpone that for now.

node ids should be a uuid v4 (random), so the distribution should be uniform.

That being said, personal spaces are created with the userid as the spaceid and the root node id to make debugging easier. We will have to assign an internal uuid or get one from the openid claims, as we need to attach roles to users anyway. But if eg. usernames (which are neither stable, reusable or persistend) are configured as uuids then the code will break for users with short names.

lgtm-com · 2022-02-17T16:37:29Z

This pull request introduces 2 alerts and fixes 2 when merging 346fdc3 into 67204fe - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-18T10:45:19Z

This pull request introduces 2 alerts and fixes 2 when merging b70cf76 into 6901ae6 - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-18T16:07:41Z

This pull request introduces 2 alerts and fixes 2 when merging 0c50ef0 into 6901ae6 - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-18T16:57:24Z

This pull request introduces 2 alerts and fixes 2 when merging c26342c into 6901ae6 - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-21T14:59:13Z

This pull request introduces 2 alerts and fixes 2 when merging 78d32d3 into 8cc813e - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-21T17:07:09Z

This pull request introduces 2 alerts and fixes 2 when merging 8beb33a into 8cc813e - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-22T14:39:02Z

This pull request introduces 2 alerts and fixes 2 when merging 36ec12d into 6e8cb77 - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-22T16:17:58Z

This pull request introduces 2 alerts and fixes 2 when merging 462b531 into f44f2a1 - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-22T16:47:12Z

This pull request introduces 2 alerts and fixes 2 when merging 5017f2c into f44f2a1 - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-22T21:17:25Z

This pull request introduces 2 alerts and fixes 2 when merging 6ac2f53 into f44f2a1 - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-22T22:01:45Z

This pull request introduces 2 alerts and fixes 2 when merging 28e3268 into f44f2a1 - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-25T13:32:39Z

This pull request introduces 2 alerts and fixes 2 when merging e3d19f0 into 8b6ec49 - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

lgtm-com · 2022-02-25T14:20:45Z

This pull request introduces 2 alerts and fixes 2 when merging 17afed9 into 8b6ec49 - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

pkg/storage/utils/decomposedfs/node/node.go

pkg/storage/utils/decomposedfs/recycle.go

Squashed commit of the following: commit 4a5e9aad8632aefbdd47229f873272af4dab320d Merge: e60fb6b a6eec6a Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Wed Feb 16 19:11:25 2022 +0000 Merge branch 'edge' into nodes-per-space commit e60fb6b Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Wed Feb 16 15:48:53 2022 +0000 fix restore Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit 15db9ad Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Wed Feb 16 15:29:33 2022 +0000 fix list trash Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit e4c1191 Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Wed Feb 16 13:55:24 2022 +0000 introduce new layout Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit dfd5eb3 Merge: 2698dc1 df1264d Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Tue Feb 15 13:15:19 2022 +0000 Merge branch 'edge' into nodes-per-space commit 2698dc1 Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Tue Feb 15 13:13:33 2022 +0000 start using correct node path Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit 2401678 Merge: 02da046 d217886 Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Tue Feb 15 10:40:30 2022 +0000 Merge branch 'edge' into nodes-per-space commit 02da046 Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Tue Feb 15 08:22:41 2022 +0000 small fixes Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit 752c692 Merge: cbc1bed c7e6607 Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Mon Feb 14 10:11:35 2022 +0000 Merge branch 'edge' into nodes-per-space commit cbc1bed Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Mon Feb 14 10:03:41 2022 +0000 remove duplicate const Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit 5a666db Author: David Christofas <dchristofas@owncloud.com> Date: Wed Jan 12 17:15:05 2022 +0100 store nodes of a space inside of the space This is still work in progress. In this state the node_test.go run successfully. commit 20a38e4 Author: kobergj <jkoberg@owncloud.com> Date: Fri Feb 11 10:31:52 2022 +0100 Events (cs3org#2522) * first draft for event system - includes example Signed-off-by: jkoberg <jkoberg@owncloud.com> * add event middleware Signed-off-by: jkoberg <jkoberg@owncloud.com> * events: distinguish grantee userid and groupid Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * seperate consumer from publisher Signed-off-by: jkoberg <jkoberg@owncloud.com> * code review suggestions Signed-off-by: jkoberg <jkoberg@owncloud.com> * simplify example Signed-off-by: jkoberg <jkoberg@owncloud.com> * add changelog Signed-off-by: jkoberg <jkoberg@owncloud.com> * make nats server configurable Signed-off-by: jkoberg <jkoberg@owncloud.com> * add license headers Signed-off-by: jkoberg <jkoberg@owncloud.com> * cheat the linter Signed-off-by: jkoberg <jkoberg@owncloud.com> Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit 65bb12a Author: Klaas Freitag <kraft@freisturz.de> Date: Thu Feb 10 15:04:17 2022 +0100 Consolidate all metadata Get's and Set's to central functions. (cs3org#2512) * Consolidate all metadata Get's and Set's to central functions. In the decomposed FS, access to xattr was spread all over. This patch consolidates that to use either the Node.SetMetadata() or xattrs.Set(). This allows us to hook in indexing for example. * hound and typos * Add changelog. * Some more fixes to use xattrs functions. * Fix function name in tests. * Fix some linting hints. * Even more linter warning fixes * Even more linting issues * And another iteration * Linter I hate you * Use proper Int formatting Co-authored-by: David Christofas <dchristofas@owncloud.com> * Update pkg/storage/utils/decomposedfs/node/node.go Co-authored-by: David Christofas <dchristofas@owncloud.com> * Update pkg/storage/utils/decomposedfs/node/node.go Co-authored-by: David Christofas <dchristofas@owncloud.com> * Update pkg/storage/utils/decomposedfs/xattrs/xattrs.go Co-authored-by: David Christofas <dchristofas@owncloud.com> * again linting * use correct variable in decomposedfs Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> Co-authored-by: David Christofas <dchristofas@owncloud.com> commit f283b98 Author: Andre Duffeck <aduffeck@users.noreply.github.com> Date: Thu Feb 10 14:48:17 2022 +0100 Upgrade to ginkgo v2, increase test coverage (cs3org#2526) * Upgrade to ginkgo v2 * Fix root info being counted twice * Do not try to list child non-containers * Improve generating response xml * DRY up code * Increase test coverage, port EncodePath benchmark to ginkgo Also add an assertion that its performanc does not decrease too much. * Add changelog * Fix hound issue * Add missing license header * Fix linter issue commit c2c5a45 Author: Klaas Freitag <kraft@freisturz.de> Date: Thu Feb 10 13:56:22 2022 +0100 Some error cleanup steps in the decomposed FS (cs3org#2511) * Some error cleanup steps in the decomposed FS * Hound and changelog added. * Remove punctuation * Make CI happy * Improved error logging. Co-authored-by: David Christofas <dchristofas@owncloud.com> * Update pkg/storage/utils/decomposedfs/decomposedfs.go Co-authored-by: David Christofas <dchristofas@owncloud.com> Co-authored-by: David Christofas <dchristofas@owncloud.com> Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit b522aab Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Wed Feb 9 11:22:41 2022 +0100 decomposedfs: add locking support (cs3org#2460) * decomposedfs: add locking support Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * add lock implementation, refactor error handling Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * introduce lock ctx Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * add locked error and status code mapping Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * read lockid from opaque into ctx for delete Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * decomposedfs: make delete respect lock Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * ocdav: simplify error code mapping Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * adjust to cs3 lock api update Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * utils: add and read plain opaque entries Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * fix delete lock Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * invalidate stat cache when setting lock Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * fix a few linter items Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * linter happyness Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * ocdav: implment unlock Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * lock caching and unlocking Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * read locks on folders Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * check lock on writes Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * always assume locktype write Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * ocis only supports exclusive locks Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * add precodition failed errtype * handle preconditionfailed in status conversion * omit empty xml tags in lockdiscovery * handle locked status on LOCK * document oc10 lock behaviour as comment * ocdav: handle errors for LOCK and UNLOCK * storage: change fs.Unlock signature * decomposedfs: refactor checkLock * add LookupReferenceForPath comment Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * gateway: ignore unimplemented add/denyGrant response Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * use http.StatusMethodNotAllowed for mkcol error case Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * make hound happy Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * ocdav: be more tolerant with the Lock-Token header Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * ocdav: allow setting infinity timeout Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * ocdav: use custem owner innerxml without href * update expected failures * ocdav: return conflict on missing intermediate target dir Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * decomposedfs: use checkLock() in the rest of cases Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * Do not choke when checking the lock of non-existent nodes * Linter fixes * Refactor: Move lock handling into the node domain * Also delete the lock file when deleting a node * Extract node lock-handling code into separate file, start writing tests * Add missing license header * Fix relocking already-locked nodes. Increase test coverage * Hounds be happy * Add unit tests for ReadLock and RefreshLock * Also cover readLocksIntoOpaque in the tests * Fix linter issue * Do not log full nodes, it's very expensive and not very helpful * Start adding grpc integration tests for locking * Fix setting the lock for file uploads * Allow for locking space-based resources * Make sure to log the error before it's getting overwritten * reuse xml.EscapeText directly Co-authored-by: David Christofas <dchristofas@posteo.de> * decomposedfs: use defer to close file when unlocking resource Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * ocdav: explain why some http states are commented Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * ocdav: use http header status constants Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * clarify add/deny grant log Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * update expected failures Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> Co-authored-by: André Duffeck <andre.duffeck@firondu.de> Co-authored-by: David Christofas <dchristofas@posteo.de> commit 4c185f9 Author: Michael Barz <mbarz@owncloud.com> Date: Tue Feb 8 14:17:16 2022 +0100 remove creation of .space folder (cs3org#2519) * remove creation of .space folder * fix unit tests * fix integration tests commit 68080f0 Author: PKiran <39373750+kiranparajuli589@users.noreply.github.com> Date: Tue Feb 8 17:58:00 2022 +0545 bump core commit id and update the expected failures (cs3org#2518) commit be39db3 Author: David Christofas <dchristofas@owncloud.com> Date: Tue Feb 8 10:16:30 2022 +0100 Cleanup code (cs3org#2516) * pre-compile the chunking regex * reduce type conversions * add changelog commit 57591c1 Author: Phil Davis <phil@jankaritech.com> Date: Mon Feb 7 12:16:34 2022 +0545 bump CORE_COMMITID to use new getPersonalSpaceIdForUser code in API tests (cs3org#2505) commit 064ec82 Author: David Christofas <dchristofas@owncloud.com> Date: Fri Feb 4 18:29:01 2022 +0100 fix propfind listing for files (cs3org#2506) commit 1aadbc8 Author: kobergj <jkoberg@owncloud.com> Date: Fri Feb 4 12:55:25 2022 +0100 [tests-only] Fix panic in storageSpaceFromNode (cs3org#2504) * fix panic in storageSpaceFromNode Signed-off-by: jkoberg <jkoberg@owncloud.com> * check node for being nil Signed-off-by: jkoberg <jkoberg@owncloud.com> * Revert "check node for being nil" This reverts commit e38228e. commit 32384aa Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com> Date: Fri Feb 4 12:48:23 2022 +0100 unprotected ocs config endpoint (cs3org#2503) * remove protection from ocs config endpoint * remove passing ocs config test from expected failures commit 27b3091 Author: kobergj <jkoberg@owncloud.com> Date: Fri Feb 4 10:49:29 2022 +0100 Restoring Spaces (cs3org#2458) * add restore functionality to decomposedfs Signed-off-by: jkoberg <jkoberg@owncloud.com> * add changelog item Signed-off-by: jkoberg <jkoberg@owncloud.com> * find trashed spaces Signed-off-by: jkoberg <jkoberg@owncloud.com> * add includeTrashed paramter to ListSpaces call Signed-off-by: jkoberg <jkoberg@owncloud.com> * only add * if neccessary Signed-off-by: jkoberg <jkoberg@owncloud.com> * move instead delete to make restore possible Signed-off-by: jkoberg <jkoberg@owncloud.com> * pass trashed information via Opaque Signed-off-by: jkoberg <jkoberg@owncloud.com> * don't return trashed space for non owners Signed-off-by: jkoberg <jkoberg@owncloud.com> * revert includeTrashed hack Signed-off-by: jkoberg <jkoberg@owncloud.com> * no need to symlink trashed spaces any more Signed-off-by: jkoberg <jkoberg@owncloud.com> * bad solution - just wanna paint it green Signed-off-by: jkoberg <jkoberg@owncloud.com> * allow listing of deleted spaces Signed-off-by: jkoberg <jkoberg@owncloud.com> commit 2754a38 Author: Phil Davis <phil@jankaritech.com> Date: Fri Feb 4 14:13:58 2022 +0545 Bump CORE_COMMITID for API tests (cs3org#2496) commit a8bfe6f Author: David Christofas <dchristofas@owncloud.com> Date: Thu Feb 3 17:54:58 2022 +0100 add grants to list-spaces (cs3org#2498) When listing storage spaces we also want to have the spaces grants to be able to show who has access to the space. Co-authored-by: kobergj <jkoberg@owncloud.com> commit 05aca63 Author: Michael Barz <mbarz@owncloud.com> Date: Thu Feb 3 16:52:34 2022 +0100 invalidate cache when modifying or deleting a space (cs3org#2500) commit 99fdf2d Author: David Christofas <dchristofas@owncloud.com> Date: Thu Feb 3 16:21:45 2022 +0100 fix spaces stat requests (cs3org#2501) commit 0443b41 Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com> Date: Tue Feb 1 21:11:17 2022 +0100 [edge] remove the ownCloud storage driver (cs3org#2495) * remove owncloud storage driver * remove owncloud storage driver integration tests and demo config files commit affffea Author: kobergj <jkoberg@owncloud.com> Date: Tue Feb 1 11:04:33 2022 +0100 [tests-only] Can't create folder names which are subset of "Shares" (cs3org#2484) * test fix with easy implementation Signed-off-by: jkoberg <jkoberg@owncloud.com> * use same logic for other above path also Signed-off-by: jkoberg <jkoberg@owncloud.com> * add special case handling to isSubPath Signed-off-by: jkoberg <jkoberg@owncloud.com> * refine isSubpath logic Signed-off-by: jkoberg <jkoberg@owncloud.com> * Stat on MKCOL before creating Signed-off-by: jkoberg <jkoberg@owncloud.com> * update comment to not include typos Signed-off-by: jkoberg <jkoberg@owncloud.com> * handle error correctly for MKCOL Signed-off-by: jkoberg <jkoberg@owncloud.com> commit a230234 Author: Amrita <54478846+amrita-shrestha@users.noreply.github.com> Date: Fri Jan 28 20:35:07 2022 +0545 Bump the commit id for tests (cs3org#2490) commit 7498491 Author: Andre Duffeck <aduffeck@users.noreply.github.com> Date: Fri Jan 28 15:32:48 2022 +0100 Make owncloudsql spaces aware (cs3org#2472) * Add ListStorages method * Implement ListStorageSpaces in owncloudsql * ResourceInfos do no longer contain the full path but only the basename * Handle references relative to a root * Fix space lookup, extract space functionality into a separate file * Use oc_mounts to find the storage roots This way it also works with storages with hashed IDs (that happens when the id exceeds a certain length). * Fix shares * Implement GetPath, fix GetPathById * Include the storage id when listing shares * Fix accepting declined shares * Ignore setting-grants-not-supported errors, storage grants are optional * Add changelog * Fix missing storage id from resource info * Fix field mask * Do not log error messages for unsupported grant calls * Fix hound issue * Fix changelog URL * Fix linter issue * Remove unfinished GetPath() code * Adapt expected failures * Cache user lookups in the oc10-sql share manager That leads to a massive performance boost. commit 5d83ded Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Fri Jan 28 09:20:13 2022 +0100 update cs3apis to include lock api changes (cs3org#2487) Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit 579aab4 Author: Phil Davis <phil@jankaritech.com> Date: Fri Jan 28 00:26:51 2022 +0545 Add end-of-line to expected-failures files (cs3org#2483) commit 2e2a3f0 Author: David Christofas <dchristofas@owncloud.com> Date: Thu Jan 27 15:46:06 2022 +0100 [tests-only] Merge master into edge (cs3org#2473) * [Build-deps] Additional rules for CODEOWNERS (cs3org#2323) * Remove share refs from trashbin (cs3org#2298) * Public link propfind (cs3org#2315) * fix public share type in propfinds (cs3org#2316) * Bump core commit id for tests (cs3org#2331) * Revert "Fix content disposition (cs3org#2303)" (cs3org#2332) This reverts commit 3cba223. * [Build-deps]: Bump github.com/gomodule/redigo from 1.8.5 to 1.8.6 (cs3org#2326) * [Build-deps]: Bump github.com/mitchellh/mapstructure from 1.4.2 to 1.4.3 (cs3org#2324) * [Build-deps]: Bump github.com/aws/aws-sdk-go from 1.42.9 to 1.42.19 (cs3org#2325) * fix app provider new file action and improve app provider error codes (cs3org#2210) * Parse URL path to determine file name (cs3org#2346) * v1.17.0 * handle non existent spaces gracefully (cs3org#2354) * Bump core commit id for tests (cs3org#2365) * [Build-deps]: Bump github.com/minio/minio-go/v7 from 7.0.16 to 7.0.18 (cs3org#2363) * [Build-deps]: Bump github.com/ReneKroon/ttlcache/v2 from 2.9.0 to 2.10.0 (cs3org#2358) * [Build-deps]: Bump go.opentelemetry.io/otel/exporters/jaeger (cs3org#2362) * fix tests by pointing to the right owncloud/core commit id for tests (cs3org#2375) * add new file capabilties to ocs for the app provider (cs3org#2379) * Remove test from expected to fail and bump commit id (cs3org#2380) * add .drone.env to CODEOWNERS as it is part of the test files (cs3org#2378) * fix webdav copy for zero byte files (cs3org#2374) * Implement touch file (cs3org#2369) * implement cs3org/cs3apis#154 * use TouchFile for the app provider * add changelog and comments * revert use TouchFile in app provider * fix resource typo Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * Dummy implementation of the Lock CS3APIs (cs3org#2350) * allow new file create with app provider on public links (cs3org#2385) * Bump core commit id and use core master for tests (cs3org#2391) * Add product to ocs Version struct (cs3org#2397) The web ui will announce the backend version in the javascript console and is supposed to include the product name as well. The version seems to be a good location for the product field as it already includes the software edition as well. * bump core commit id for tests (cs3org#2404) * [Build-deps]: Bump github.com/mattn/go-sqlite3 from 1.14.9 to 1.14.10 (cs3org#2409) * [Build-deps]: Bump github.com/minio/minio-go/v7 from 7.0.18 to 7.0.20 (cs3org#2408) * [Build-deps]: Bump github.com/rs/cors from 1.8.0 to 1.8.2 (cs3org#2399) * [Build-deps]: Bump github.com/ReneKroon/ttlcache/v2 (cs3org#2387) * [Build-deps]: Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc (cs3org#2359) * [tests-only] format .drone.star (cs3org#2411) * update tus/tusd to version 1.8.0 (cs3org#2393) * Fixes for apps in public shares, project spaces for EOS driver (cs3org#2371) * [Build-deps]: Bump github.com/aws/aws-sdk-go from 1.42.19 to 1.42.27 (cs3org#2414) * [Build-deps]: Bump github.com/rs/zerolog from 1.26.0 to 1.26.1 (cs3org#2388) * update owncloud core commit id (cs3org#2418) * [Build-deps]: Bump github.com/mattn/go-sqlite3 (cs3org#2425) * [Build-deps]: Bump github.com/gomodule/redigo from 1.8.6 to 1.8.8 (cs3org#2426) * OIDC and WOPI changes for lightweight users (cs3org#2278) * [tests-only]Bump the commit id for tests (cs3org#2441) * Bump the commit id for tests * Adding failing tests to expected to failure * CephFS Reva v0.2 (cs3org#1209) * [Build-deps]: Bump github.com/minio/minio-go/v7 from 7.0.20 to 7.0.21 (cs3org#2449) * [Build-deps]: Bump github.com/hashicorp/go-hclog from 1.0.0 to 1.1.0 (cs3org#2448) * [Build-deps]: Bump github.com/BurntSushi/toml from 0.4.1 to 1.0.0 (cs3org#2446) * revert go-sqlite downgrade (cs3org#2461) * [Build-deps]: Bump github.com/google/go-cmp from 0.5.6 to 0.5.7 (cs3org#2466) * [Build-deps]: Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.39 (cs3org#2467) * [Build-deps]: Bump github.com/ceph/go-ceph from 0.12.0 to 0.13.0 (cs3org#2468) * [Build-deps]: Bump github.com/onsi/gomega from 1.17.0 to 1.18.0 (cs3org#2469) * Use permissions API in decomposedfs (cs3org#2341) * [tests-only]Bump Core Commit Id (cs3org#2451) * Bump commit id for tests 2022-01-25 (cs3org#2474) * Bump commit id for issue-ocis-3030 (cs3org#2476) * fix test failures * fix integration tests Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> Co-authored-by: Gianmaria Del Monte <39946305+gmgigi96@users.noreply.github.com> Co-authored-by: Swikriti Tripathi <41103328+SwikritiT@users.noreply.github.com> Co-authored-by: Ishank Arora <ishank011@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Willy Kloucek <34452982+wkloucek@users.noreply.github.com> Co-authored-by: Michael Barz <mbarz@owncloud.com> Co-authored-by: Phil Davis <phil@jankaritech.com> Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz> Co-authored-by: Saw-jan Gurung <saw.jan.grg3e@gmail.com> Co-authored-by: PKiran <39373750+kiranparajuli589@users.noreply.github.com> Co-authored-by: Mouratidis Theofilos <mtheofilos@gmail.com> Co-authored-by: Amrita <54478846+amrita-shrestha@users.noreply.github.com> commit 2329e29 Author: Amrita <54478846+amrita-shrestha@users.noreply.github.com> Date: Wed Jan 26 15:54:59 2022 +0545 Bump commit id for ocis issue 3030 (cs3org#2477) commit 1488412 Author: Phil Davis <phil@jankaritech.com> Date: Wed Jan 26 10:26:56 2022 +0545 Bump commit id for tests 2022-01-25 (edge) (cs3org#2475) commit 2a46af9 Author: Amrita <54478846+amrita-shrestha@users.noreply.github.com> Date: Mon Jan 24 20:56:46 2022 +0545 [tests-only]Bump the commit id for tests (cs3org#2453) * Bump the commit id for tests * skip personalSpace tests for now * skip issue-ocis-3023 tests to avoid infinite loop Co-authored-by: Phil Davis <phil@jankaritech.com> commit bc20acb Author: kobergj <jkoberg@owncloud.com> Date: Fri Jan 21 14:48:12 2022 +0100 Space grants (cs3org#2464) * send spacegrants and pass them to decomposedfs Signed-off-by: jkoberg <jkoberg@owncloud.com> * add changelog item Signed-off-by: jkoberg <jkoberg@owncloud.com> commit d07d63e Author: Andre Duffeck <aduffeck@users.noreply.github.com> Date: Fri Jan 21 12:28:11 2022 +0100 Do not log nodes (cs3org#2463) * Do not log whole nodes It turns out that logging whole node objects is very expensive and also spams the logs quite a bit. Instead we just log the node ID now. * Add changelog commit c68b5cd Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com> Date: Fri Jan 21 09:19:24 2022 +0100 revert downgrade of mattn/go-sqlite (cs3org#2462) commit a799b5c Author: kobergj <juliankoberg@googlemail.com> Date: Thu Jan 20 16:47:28 2022 +0100 Make gateway dumb again (cs3org#2437) * make StatHandler dumb again Signed-off-by: jkoberg <jkoberg@owncloud.com> * add changelog Signed-off-by: jkoberg <jkoberg@owncloud.com> * use findAndUnwrap instead find Signed-off-by: jkoberg <jkoberg@owncloud.com> * kinda fix integration tests Signed-off-by: jkoberg <jkoberg@owncloud.com> * remove ListContainer logic Signed-off-by: jkoberg <jkoberg@owncloud.com> * decomposedfs: don't check id's containing "/" Signed-off-by: jkoberg <jkoberg@owncloud.com> * fix linting and integration tests Signed-off-by: jkoberg <jkoberg@owncloud.com> * make ListRecycle dumb again Signed-off-by: jkoberg <jkoberg@owncloud.com> * make RestoreRecycleItem dumb again Signed-off-by: jkoberg <jkoberg@owncloud.com> * don't allow cross storage restore Signed-off-by: jkoberg <jkoberg@owncloud.com> * make Move dumb again Signed-off-by: jkoberg <jkoberg@owncloud.com> * make GetPath dumb again Signed-off-by: jkoberg <jkoberg@owncloud.com> * try changing dav report response Signed-off-by: jkoberg <jkoberg@owncloud.com> * add missing import Signed-off-by: jkoberg <jkoberg@owncloud.com> * blind mans fix for favorites Signed-off-by: jkoberg <jkoberg@owncloud.com> * remove commented code and nasty bug Signed-off-by: jkoberg <jkoberg@owncloud.com> * Update internal/http/services/owncloud/ocdav/propfind/propfind.go Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> * Update internal/http/services/owncloud/ocdav/report.go Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> * Update internal/http/services/owncloud/ocdav/report.go Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit 0880fa8 Author: David Christofas <dchristofas@owncloud.com> Date: Thu Jan 20 16:46:49 2022 +0100 prevent purging of enabled spaces (cs3org#2459) commit a955d62 Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Thu Jan 20 13:03:48 2022 +0100 decomposedfs: do not swallow errors when creating nodes (cs3org#2457) Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit 4f84896 Author: Michael Barz <mbarz@owncloud.com> Date: Wed Jan 19 11:27:16 2022 +0100 fix path construction in webdav propfind (cs3org#2454) commit 53037a0 Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Tue Jan 18 11:41:40 2022 +0100 fix create space error message (cs3org#2452) Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit bb960af Author: David Christofas <dchristofas@owncloud.com> Date: Mon Jan 17 17:43:34 2022 +0100 Purge spaces (cs3org#2431) * purge shares when purging storage spaces When purging a space we also want to delete all shares in that space. This is a first naive implementation for that but ideally we want to solve the with an event system eventually to decouple the services. * purge spaces in the storage driver Spaces can now be purged in a two step process. The code currently doesn't purge the blobs though. * implement review remarks * prevent normal users from listing deleted spaces * refactor share storage id filter * implement review remarks * list correct number of trashed spaces Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit b061960 Author: kobergj <jkoberg@owncloud.com> Date: Fri Jan 14 11:48:03 2022 +0100 Fix publiclinks and decomposedfs (cs3org#2445) * decomposedfs: don't check id's containing "/" Signed-off-by: jkoberg <jkoberg@owncloud.com> * add changelog Signed-off-by: jkoberg <jkoberg@owncloud.com> commit c4d0c64 Author: Swikriti Tripathi <41103328+SwikritiT@users.noreply.github.com> Date: Fri Jan 14 10:59:10 2022 +0545 [tests-only]Bump the commit id for tests edge (cs3org#2442) * Bump the commit id for tests * Adding failing tests to expected to failure commit c739713 Author: kobergj <jkoberg@owncloud.com> Date: Thu Jan 13 16:59:33 2022 +0100 fix statcache logic (cs3org#2440) Signed-off-by: jkoberg <jkoberg@owncloud.com> commit 1ed9c9f Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Thu Jan 13 16:58:47 2022 +0100 ignore handled errors when creating spaces (cs3org#2439) Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit 8a956f3 Author: Ralf Haferkamp <rhaferkamp@owncloud.com> Date: Wed Jan 12 20:16:39 2022 +0100 Adjust "groupfilter" to be able to search by member name (cs3org#2436) Previously the input for the LDAP Groupfilter to lookup all groups a specific user is member of was the userpb.UserId part of the User object. I.e. it assumed we could run a single LDAP query to get all groups a user is member of by specifying the userid. However most LDAP Servers store the GroupMembership by either username (e.g. in memberUID Attribute) or by the user's DN (e.g. in member/uniqueMember). The GetUserGroups method was already updated recently to do a two-staged lookup (first lookup the user's name by Id then search the Groups by username). This change just removes the userpb.UserId template processing from the GroupFilter and replaces it with a single string (the username) to get rid of the annoying `{{.}}` template values in the config. In the future we should add a config switch to also allow lookups by member DN. commit 626d28a Author: kobergj <jkoberg@owncloud.com> Date: Wed Jan 12 16:57:28 2022 +0100 [tests-only] Merge master into edge (cs3org#2435) * [Build-deps] Additional rules for CODEOWNERS (cs3org#2323) * Remove share refs from trashbin (cs3org#2298) * Public link propfind (cs3org#2315) * fix public share type in propfinds (cs3org#2316) * Bump core commit id for tests (cs3org#2331) * Revert "Fix content disposition (cs3org#2303)" (cs3org#2332) This reverts commit 3cba223. * [Build-deps]: Bump github.com/gomodule/redigo from 1.8.5 to 1.8.6 (cs3org#2326) * [Build-deps]: Bump github.com/mitchellh/mapstructure from 1.4.2 to 1.4.3 (cs3org#2324) * [Build-deps]: Bump github.com/aws/aws-sdk-go from 1.42.9 to 1.42.19 (cs3org#2325) * fix app provider new file action and improve app provider error codes (cs3org#2210) * Parse URL path to determine file name (cs3org#2346) * v1.17.0 * handle non existent spaces gracefully (cs3org#2354) * Bump core commit id for tests (cs3org#2365) * [Build-deps]: Bump github.com/minio/minio-go/v7 from 7.0.16 to 7.0.18 (cs3org#2363) * [Build-deps]: Bump github.com/ReneKroon/ttlcache/v2 from 2.9.0 to 2.10.0 (cs3org#2358) * [Build-deps]: Bump go.opentelemetry.io/otel/exporters/jaeger (cs3org#2362) * fix tests by pointing to the right owncloud/core commit id for tests (cs3org#2375) * add new file capabilties to ocs for the app provider (cs3org#2379) * Remove test from expected to fail and bump commit id (cs3org#2380) * add .drone.env to CODEOWNERS as it is part of the test files (cs3org#2378) * fix webdav copy for zero byte files (cs3org#2374) * Implement touch file (cs3org#2369) * implement cs3org/cs3apis#154 * use TouchFile for the app provider * add changelog and comments * revert use TouchFile in app provider * fix resource typo Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> * Dummy implementation of the Lock CS3APIs (cs3org#2350) * allow new file create with app provider on public links (cs3org#2385) * Bump core commit id and use core master for tests (cs3org#2391) * Add product to ocs Version struct (cs3org#2397) The web ui will announce the backend version in the javascript console and is supposed to include the product name as well. The version seems to be a good location for the product field as it already includes the software edition as well. * bump core commit id for tests (cs3org#2404) * [Build-deps]: Bump github.com/mattn/go-sqlite3 from 1.14.9 to 1.14.10 (cs3org#2409) * [Build-deps]: Bump github.com/minio/minio-go/v7 from 7.0.18 to 7.0.20 (cs3org#2408) * [Build-deps]: Bump github.com/rs/cors from 1.8.0 to 1.8.2 (cs3org#2399) * [Build-deps]: Bump github.com/ReneKroon/ttlcache/v2 (cs3org#2387) * [Build-deps]: Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc (cs3org#2359) * [tests-only] format .drone.star (cs3org#2411) * update tus/tusd to version 1.8.0 (cs3org#2393) * Fixes for apps in public shares, project spaces for EOS driver (cs3org#2371) * [Build-deps]: Bump github.com/aws/aws-sdk-go from 1.42.19 to 1.42.27 (cs3org#2414) * [Build-deps]: Bump github.com/rs/zerolog from 1.26.0 to 1.26.1 (cs3org#2388) * update owncloud core commit id (cs3org#2418) * [Build-deps]: Bump github.com/mattn/go-sqlite3 (cs3org#2425) * [Build-deps]: Bump github.com/gomodule/redigo from 1.8.6 to 1.8.8 (cs3org#2426) * OIDC and WOPI changes for lightweight users (cs3org#2278) * don't create references in gateway Signed-off-by: jkoberg <jkoberg@owncloud.com> * don't run virtual views testsuite Signed-off-by: jkoberg <jkoberg@owncloud.com> * bring back token scope expanding Signed-off-by: jkoberg <jkoberg@owncloud.com> Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch> Co-authored-by: Gianmaria Del Monte <39946305+gmgigi96@users.noreply.github.com> Co-authored-by: David Christofas <dchristofas@owncloud.com> Co-authored-by: Swikriti Tripathi <41103328+SwikritiT@users.noreply.github.com> Co-authored-by: Ishank Arora <ishank011@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Willy Kloucek <34452982+wkloucek@users.noreply.github.com> Co-authored-by: Michael Barz <mbarz@owncloud.com> Co-authored-by: Phil Davis <phil@jankaritech.com> Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz> Co-authored-by: Saw-jan Gurung <saw.jan.grg3e@gmail.com> Co-authored-by: PKiran <39373750+kiranparajuli589@users.noreply.github.com> commit 6b8e690 Author: Andre Duffeck <aduffeck@users.noreply.github.com> Date: Wed Jan 12 09:50:26 2022 +0100 Start splitting up ocdav (cs3org#2434) * Start splitting up ocdav into smaller chunks That increases clarity and allows for making things testable. * Add a basic propfind unit test * Fix linter and hound issues * Add changelog commit 9e2e91c Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Tue Jan 11 17:03:07 2022 +0100 fix shares provider filter (cs3org#2433) Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit 5c6d949 Author: Jörn Friedrich Dreyer <jfd@butonic.de> Date: Tue Jan 11 16:03:47 2022 +0100 use space reference when listing containers (cs3org#2432) Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> commit 2469457 Author: David Christofas <dchristofas@owncloud.com> Date: Wed Jan 12 17:15:05 2022 +0100 store nodes of a space inside of the space This is still work in progress. In this state the node_test.go run successfully. refactor lookup and Pathify Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> add changelog Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> add missing lookup package Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> wipe spaces after tests Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix tests Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> drop lookup RootNode() Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> make spaces litmus pick up correct id Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix more tests Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> cosmetic fixes Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix lock tests Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix fileid Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix list recycle item Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix trash depth infinity Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix trash restore Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix restore propagation Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> linter happyness Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix build Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix restore child item Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> update expected failures Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> only root nodes may have an owner Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix trash Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix tree tests Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> check CreateContainer permission when creating space Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> add create-space permission check Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> happy mocking Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> add license header Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> permissions demo: add create-space Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> linter Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> use dedicated permissionssvc config Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> linter Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> actually test nextcloud driver m( Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> integration tests: use permissionssvc Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> update integration tests Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> integration tests Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix storage integration ocis versions Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> demo permissions: allow create space Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> fix integration tests Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> linter, remove dead code Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

lgtm-com · 2022-02-28T16:49:05Z

This pull request introduces 2 alerts and fixes 2 when merging b55bae1 into 3e80be7 - view on LGTM.com

new alerts:

2 for Uncontrolled data used in path expression

fixed alerts:

2 for Uncontrolled data used in path expression

butonic requested a review from a team as a code owner February 16, 2022 15:49

butonic marked this pull request as draft February 16, 2022 15:49

butonic force-pushed the nodes-per-space branch from e60fb6b to 1abfeb4 Compare February 16, 2022 19:17

micbar reviewed Feb 16, 2022

View reviewed changes

butonic force-pushed the nodes-per-space branch from 5713bc0 to 63c0dc9 Compare February 17, 2022 09:17

butonic force-pushed the nodes-per-space branch from 113074e to b70cf76 Compare February 18, 2022 10:24

butonic force-pushed the nodes-per-space branch from e30f40d to 6ac2f53 Compare February 22, 2022 20:56

butonic force-pushed the nodes-per-space branch from e3d19f0 to 17afed9 Compare February 25, 2022 13:55

butonic requested a review from micbar February 25, 2022 15:24

butonic marked this pull request as ready for review February 28, 2022 10:16

butonic requested review from labkode, ishank011 and glpatcern as code owners February 28, 2022 10:16

C0rby reviewed Feb 28, 2022

View reviewed changes

pkg/storage/utils/decomposedfs/node/node.go Outdated Show resolved Hide resolved

pkg/storage/utils/decomposedfs/node/node.go Show resolved Hide resolved

pkg/storage/utils/decomposedfs/recycle.go Outdated Show resolved Hide resolved

micbar mentioned this pull request Feb 28, 2022

Release 1.18.0 Tech Preview owncloud/ocis#3244

Closed

26 tasks

butonic added 6 commits February 28, 2022 15:13

fix space disable/reenable/purge

2fde139

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

fix share spaces

f1e9c5a

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

linter

68ba2f8

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

decomposedfs: check grants on space root

c632c8e

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

update not exists error handling

69b0f36

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

butonic force-pushed the nodes-per-space branch from 17afed9 to 69b0f36 Compare February 28, 2022 16:19

fix locks

b55bae1

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

micbar requested a review from C0rby February 28, 2022 16:27

C0rby approved these changes Feb 28, 2022

View reviewed changes

butonic merged commit 1fd81b0 into cs3org:edge Mar 1, 2022

butonic deleted the nodes-per-space branch March 1, 2022 07:19

pascalwengerter mentioned this pull request Mar 23, 2022

Release 1.19.0 Tech Preview owncloud/ocis#3377

Closed

22 tasks

kobergj mentioned this pull request Oct 14, 2022

[tests-only] FixRescanning #3355

Merged

kiranparajuli589 mentioned this pull request Oct 20, 2022

[tests-only][full-ci] bump owncloud core commit for the tests (edge) #3380

Merged

kiranparajuli589 mentioned this pull request Oct 28, 2022

[tests-only][full-ci] Bump the oC/core commit ID for the tests" #3411

Merged

kobergj mentioned this pull request Dec 19, 2022

Fix Tags pkg #3564

Merged

kobergj mentioned this pull request May 22, 2023

Use defer to invalidate ID Cache #3910

Closed

kobergj mentioned this pull request Mar 1, 2024

Extend ServiceAccount Permissions #4544

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

decomposedfs: shard nodes per space #2554

decomposedfs: shard nodes per space #2554

butonic commented Feb 16, 2022 •

edited

Loading

update-docs bot commented Feb 16, 2022

lgtm-com bot commented Feb 16, 2022

micbar commented Feb 16, 2022

micbar Feb 16, 2022

lgtm-com bot commented Feb 16, 2022

lgtm-com bot commented Feb 16, 2022

lgtm-com bot commented Feb 16, 2022

lgtm-com bot commented Feb 17, 2022

lgtm-com bot commented Feb 17, 2022

lgtm-com bot commented Feb 17, 2022

labkode commented Feb 17, 2022

lgtm-com bot commented Feb 17, 2022

butonic commented Feb 17, 2022

lgtm-com bot commented Feb 17, 2022

lgtm-com bot commented Feb 18, 2022

lgtm-com bot commented Feb 18, 2022

lgtm-com bot commented Feb 18, 2022

lgtm-com bot commented Feb 21, 2022

lgtm-com bot commented Feb 21, 2022

lgtm-com bot commented Feb 22, 2022

lgtm-com bot commented Feb 22, 2022

lgtm-com bot commented Feb 22, 2022

lgtm-com bot commented Feb 22, 2022

lgtm-com bot commented Feb 22, 2022

lgtm-com bot commented Feb 25, 2022

lgtm-com bot commented Feb 25, 2022

lgtm-com bot commented Feb 28, 2022

decomposedfs: shard nodes per space #2554

decomposedfs: shard nodes per space #2554

Conversation

butonic commented Feb 16, 2022 • edited Loading

update-docs bot commented Feb 16, 2022

lgtm-com bot commented Feb 16, 2022

micbar commented Feb 16, 2022

micbar Feb 16, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Feb 16, 2022

lgtm-com bot commented Feb 16, 2022

lgtm-com bot commented Feb 16, 2022

lgtm-com bot commented Feb 17, 2022

lgtm-com bot commented Feb 17, 2022

lgtm-com bot commented Feb 17, 2022

labkode commented Feb 17, 2022

lgtm-com bot commented Feb 17, 2022

butonic commented Feb 17, 2022

lgtm-com bot commented Feb 17, 2022

lgtm-com bot commented Feb 18, 2022

lgtm-com bot commented Feb 18, 2022

lgtm-com bot commented Feb 18, 2022

lgtm-com bot commented Feb 21, 2022

lgtm-com bot commented Feb 21, 2022

lgtm-com bot commented Feb 22, 2022

lgtm-com bot commented Feb 22, 2022

lgtm-com bot commented Feb 22, 2022

lgtm-com bot commented Feb 22, 2022

lgtm-com bot commented Feb 22, 2022

lgtm-com bot commented Feb 25, 2022

lgtm-com bot commented Feb 25, 2022

lgtm-com bot commented Feb 28, 2022

butonic commented Feb 16, 2022 •

edited

Loading