Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return early on ocdav move requests with body #2974

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Jun 15, 2022

Added a check if a ocdav move request contains a body. If it does a 415 415 (Unsupported Media Type) will be returned.

https://datatracker.ietf.org/doc/html/rfc4918#section-8.4

@C0rby C0rby merged commit 1d12472 into cs3org:edge Jun 15, 2022
@C0rby C0rby deleted the ocdav-move-body branch June 15, 2022 13:20
@phil-davis
Copy link
Contributor

Note: I added a core issue to make a couple of API test scenarios for this owncloud/core#40144
We might like to make oC10 behave to-spec for this in the future. And we should also check that COPY and DELETE requests in reva/oCIS have this 415 behavior. The new test will come in a commit-id update in the next week or so, that will clearly show if COPY and DELETE are behaving correctly or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants