Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test scenarios for DELETE, COPY and MOVE with body #40144

Closed
phil-davis opened this issue Jun 16, 2022 · 2 comments
Closed

Add test scenarios for DELETE, COPY and MOVE with body #40144

phil-davis opened this issue Jun 16, 2022 · 2 comments
Assignees
Labels

Comments

@phil-davis
Copy link
Contributor

webDAV DELETE, COPY or MOVE requests should not send a body in the request.
https://datatracker.ietf.org/doc/html/rfc4918#section-8.4

The happy-path test scenarios were adjusted so that they do not send bodies in such requests - see issue #40126

If a body is sent, then the server is supposed to return HTTP status 415 (Unsupported Media Type):
https://datatracker.ietf.org/doc/html/rfc4918#section-8.4

This has been implemented in reva PR cs3org/reva#2974 for MOVE requests, and might need implementing for COPY and DELETE requests.

oC10 does not return 415 at this time.

Add test scenarios for DELETE, COPY and MOVE that purposely send a body in the request and expect HTTP status 415. Make scenarios that do this in a user's own personal storage, and in/out of a received share.

The test scenarios will likely fail on oC10, so skip them on oC10, and allow them to run for oCIS/reva. Create a bug issue for oC10 describing the non-compliant behavior, and some scenarios that demonstrate the non-compliant behavior. Let those scenarios run on oC10, and skip them for oCIS/reva. Someone can then easily decide to fix the behavior of oC10 and it will be easy for the developer to adjust the test suite etc.

@grgprarup
Copy link
Contributor

grgprarup commented Aug 1, 2022

TODO:

@grgprarup
Copy link
Contributor

grgprarup commented Aug 5, 2022

Since the implementation for COPY and DELETE requests to return HTTP 415 is not done yet for oCIS/Reva. Issue: owncloud/ocis#4332
The remaining task could be done after #4332 is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants