Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] added tests for DELETE request endpoints with body #40298

Merged
merged 3 commits into from
Aug 17, 2022
Merged

[tests-only] added tests for DELETE request endpoints with body #40298

merged 3 commits into from
Aug 17, 2022

Conversation

kiranadh1452
Copy link
Contributor

Description

This PR adds the test for the DELETE request to endpoints with body for oCIS backend.

Related Issue

Motivation and Context

https://datatracker.ietf.org/doc/html/rfc4918#section-8.4
If a body is sent, then the server is supposed to return HTTP status 415 (Unsupported Media Type).

How Has This Been Tested?

  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@kiranadh1452 kiranadh1452 self-assigned this Aug 17, 2022
SwikritiT
SwikritiT reviewed Aug 17, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

grgprarup
grgprarup reviewed Aug 17, 2022
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

saw-jan
saw-jan reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phil-davis phil-davis merged commit f79fbff into master Aug 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-tests-for-delete-endpoints branch August 17, 2022 16:45
@grgprarup grgprarup mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@grgprarup grgprarup grgprarup left review comments

@phil-davis phil-davis phil-davis approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@sushmita56 sushmita56 Awaiting requested review from sushmita56

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@kiranadh1452 kiranadh1452

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kiranadh1452 @phil-davis @grgprarup @SwikritiT @saw-jan