Fixed possible null pointer dereference in ldap authprovider #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
rhafer
force-pushed
the
ldapauth
branch
2 times, most recently
from
1395619 to
a713259
Compare
|
This pull request fixes 1 alert when merging a713259 into 6b31c62 - view on LGTM.com fixed alerts:
|
Return a proper error the userprovider is returning a not OK status code. Also add some more logging to be able to recognize configuration issue more easily (e.g. a mismatch in the IDP settings of the auth/user-providers)
|
This pull request fixes 1 alert when merging ae7f9bc into 08f504f - view on LGTM.com fixed alerts:
|
wkloucek
approved these changes
Jul 19, 2022
26 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return a proper error the userprovider is returning a not OK status
code. Also add some more logging to be able to recognize configuration
issue more easily (e.g. a mismatch in the IDP settings of the
auth/user-providers)