Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use NATS JetStream #2574

Merged
merged 5 commits into from
Mar 24, 2022
Merged

use NATS JetStream #2574

merged 5 commits into from
Mar 24, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Feb 21, 2022 •
edited
Loading

NATS Streaming is depreciated in favor of NATS JetStream.

Please also see changes in owncloud/ocis#3192

@update-docs
Copy link

update-docs bot commented Feb 21, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek mentioned this pull request Feb 28, 2022
Merged
9 tasks
@wkloucek wkloucek changed the title use nats jetstream use NATS JetStream Mar 1, 2022
@wkloucek wkloucek marked this pull request as ready for review March 11, 2022 08:12
@wkloucek wkloucek requested review from kobergj and C0rby and removed request for a team, labkode, glpatcern and ishank011 March 11, 2022 08:13
kobergj
kobergj requested changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some smaller ones...

internal/grpc/interceptors/eventsmiddleware/events.go Outdated Show resolved Hide resolved
internal/grpc/interceptors/eventsmiddleware/events.go Outdated Show resolved Hide resolved
pkg/events/example/example.go Outdated Show resolved Hide resolved
pkg/events/example/example.go Outdated Show resolved Hide resolved
pkg/events/server/nats.go Outdated Show resolved Hide resolved
@wkloucek wkloucek requested a review from kobergj March 14, 2022 07:28
kobergj
kobergj reviewed Mar 14, 2022
View reviewed changes
pkg/events/server/nats.go Outdated Show resolved Hide resolved
@wkloucek wkloucek requested a review from kobergj March 14, 2022 13:27
@butonic
Copy link
Contributor

butonic commented Mar 22, 2022

we should update owncloud/ocis#3192

@wkloucek wkloucek merged commit 82800d7 into cs3org:edge Mar 24, 2022
@wkloucek wkloucek deleted the use-nats-jetstream branch March 24, 2022 07:17
wkloucek added a commit to owncloud/ocis that referenced this pull request Mar 24, 2022
@wkloucek
update reva to have cs3org/reva#2574
b2b11c4
@micbar micbar mentioned this pull request Mar 29, 2022
Closed
22 tasks
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @butonic @kobergj