Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] use NATS JetStream #3192

Merged
merged 10 commits into from
Mar 24, 2022
Merged

[full-ci] use NATS JetStream #3192

merged 10 commits into from
Mar 24, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Feb 17, 2022 •
edited
Loading

Description

  • use NATS JetStream

Related Issue

Motivation and Context

  • NATS Streaming is depreciated

How Has This Been Tested?

  • manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Feb 17, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek marked this pull request as ready for review February 18, 2022 10:56
@ownclouders
Copy link
Contributor

ownclouders commented Feb 18, 2022 •
edited
Loading

💥 Acceptance test localApiTests-apiAccountsHashDifficulty-ocis failed. Further test are cancelled...

@wkloucek wkloucek marked this pull request as draft February 18, 2022 12:34
@wkloucek wkloucek changed the title check running nats server for errors use NATS JetStream Mar 1, 2022
@wkloucek wkloucek force-pushed the nats-check-for-error branch 2 times, most recently from 7e79093 to e9a6047 Compare March 11, 2022 08:03
@wkloucek wkloucek mentioned this pull request Mar 11, 2022
Merged
@wkloucek wkloucek marked this pull request as ready for review March 11, 2022 08:15
kobergj
kobergj requested changes Mar 17, 2022
View reviewed changes
nats/pkg/command/server.go Outdated Show resolved Hide resolved
nats/pkg/server/nats/nats.go Outdated Show resolved Hide resolved
nats/pkg/server/nats/nats.go Outdated Show resolved Hide resolved
nats/pkg/server/nats/nats.go Outdated Show resolved Hide resolved
notifications/pkg/command/server.go Outdated Show resolved Hide resolved
@wkloucek wkloucek requested a review from kobergj March 23, 2022 09:33
kobergj
kobergj reviewed Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just one open question

@wkloucek wkloucek changed the title use NATS JetStream [full-ci] use NATS JetStream Mar 24, 2022
kobergj
kobergj approved these changes Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍 Even lines deleted totally...

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
3.0% 3.0% Duplication

@wkloucek wkloucek merged commit 4f13ac6 into master Mar 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the nats-check-for-error branch March 24, 2022 12:08
ownclouders pushed a commit that referenced this pull request Mar 24, 2022
@wkloucek
commit 4f13ac6
6f62f2f 
Merge: b0745e1 90d5ef3
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Thu Mar 24 13:08:15 2022 +0100

    Merge pull request #3192 from owncloud/nats-check-for-error

    [full-ci] use NATS JetStream
@micbar micbar mentioned this pull request Mar 29, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @ownclouders @kobergj