add NATS JetStream events plugin #2433
Conversation
|
|
||
| // parse the options | ||
| options := events.ConsumeOptions{ | ||
| Group: uuid.New().String(), |
There was a problem hiding this comment.
Group name should be defineable. I want multiple services listening in the same group
There was a problem hiding this comment.
That's just a "default" group if you don't provide one via the opts.
If you provide one, it'll be set in the next few lines:
for _, o := range opts {
o(&options)
}
|
Thanks for the contribution. Think the test is failing on something unrelated. Looking for a reviewer. |
| } | ||
|
|
||
| pubOpts := []nats.PubOpt{ | ||
| // TODO: to make de-duplication work, we need to pass the event from the outside as an option |
There was a problem hiding this comment.
@asim would be de-duplication a thing we want to support? I'm not sure if it can be supported by other event implementations.
https://docs.nats.io/using-nats/developer/develop_jetstream/model_deep_dive#message-deduplication
| ctx, cancel := context.WithCancel(context.TODO()) | ||
| defer cancel() | ||
|
|
||
| // TODO: not supported by go-micro interface |
There was a problem hiding this comment.
@asim NATS Jetstream supports "stretching" the message ACK timeout (options.AckWait) but that would need exposing a InProgressFunc to the events channel consumer. Is that something we want and can support with other implementations? see https://docs.nats.io/using-nats/developer/develop_jetstream/model_deep_dive -> AckProgress
There was a problem hiding this comment.
I think its best to do it in an isolated case specifically for this. You can see the rabbitmq broker plugin for implementation specific options that can be passed through. It's not clear that other implementations would support it so we'd inherit an option nothing can deal with.
|
Thanks a lot for this pull <3 |
Introduce a NATS JetStream events plugin, since go-micro currently only supports NATS Streaming, which is depreceated.