Clean IDCache properly #3903
Merged
Clean IDCache properly #3903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
force-pushed
the
CleanIDCacheProperly
branch
from
00a4865
to
018f7d9
Compare
kobergj
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
2403905
approved these changes
May 19, 2023
aduffeck
reviewed
May 22, 2023
| @@ -416,6 +416,10 @@ func (t *Tree) ListFolder(ctx context.Context, n *node.Node) ([]*node.Node, erro | |||
|
|
|||
| // Delete deletes a node in the tree by moving it to the trash | |||
| func (t *Tree) Delete(ctx context.Context, n *node.Node) (err error) { | |||
| path := filepath.Join(n.ParentPath(), n.Name) | |||
| // remove entry from cache immediately to avoid inconsistencies | |||
| _ = t.idCache.Delete(path) | |||
There was a problem hiding this comment.
Little nitpick: Wouldn't it be safer to invalidate the cache after actually having deleted the file? Otherwise the cache could be filled again by another goroutine or instance between here and line 499, no?
butonic
approved these changes
May 22, 2023
This was referenced May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs more work. Cache can't work like this on distributed systemsDecided to use a (configurable) go-micro store instead of the hardcoded inmemory implementation