Migrate to msgpack #3728
Merged
Migrate to msgpack #3728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remember migration states to not run migrations over and over again.
butonic
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
butonic
approved these changes
Mar 15, 2023
butonic
reviewed
Mar 15, 2023
Comment on lines
82
to
87
| m.log.Info().Msg("Skipping finished migration " + migration + "...") | ||
| continue | ||
| case "": | ||
| m.log.Info().Msg("Running migration " + migration + "...") | ||
| default: | ||
| m.log.Info().Msg("Re-running migration " + migration + "...") |
There was a problem hiding this comment.
we should probably drop any logs that show up during startup unless a migration actually needs to happen. We can think of passing down a logger or better just context the whole chain of services to clean this up in a subsequent PR.
But for now lets silence these logs, ok?
There was a problem hiding this comment.
Sure, I'll push an according commit soon.
butonic
approved these changes
Mar 15, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.