Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share expiration #3594

Merged
merged 6 commits into from
Jan 12, 2023
Merged

Share expiration #3594

merged 6 commits into from
Jan 12, 2023

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Jan 10, 2023

Shares can have an expiration timestamp. If they are accessed after the expiration, the share will automatically be removed.

Todo:

@update-docs
Copy link

update-docs bot commented Jan 10, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@C0rby C0rby force-pushed the share-expiration branch 9 times, most recently from 7e9b40b to 0fe0534 Compare January 11, 2023 11:35
@C0rby C0rby force-pushed the share-expiration branch 2 times, most recently from 16f85cc to b6c1d39 Compare January 12, 2023 14:24
butonic
butonic approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the ISO8601 pain, the updatemask introduction which causes changes in all implementations and the cs3api replacement. All of which we can address in subsequent PRs. Good to go!

@C0rby C0rby marked this pull request as ready for review January 12, 2023 15:02
@C0rby C0rby requested review from a team, labkode, ishank011 and glpatcern as code owners January 12, 2023 15:02
@C0rby C0rby merged commit e955451 into cs3org:edge Jan 12, 2023
@C0rby C0rby deleted the share-expiration branch January 12, 2023 15:16
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@C0rby @butonic