Tracing improvements #2962
Merged
Tracing improvements #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Create separate TracerProviders per service to improve tracing when running multiple services in a single process (like e.g. ocis does). Previously all service were referring to the same package-level TracerProvider (which, among other things, caused the services to overwrite each others services names). We still create a "global" TracerProvider to cover the cases where we don't have access to the per service Provider yet. This will be improved in a follow up change.
To generate more useful tracing (especially when running multiple services in a single process) we'd like to generate Tracers from the per service TracerProvider() instead of the global default provider. Therefore we now pass the TracerProvider via context (similar to what is already done for the logger.
|
I must admit I am not really sure about the whole change (especially the second commit in the PR). I am not a fan of attaching this kind of stuff to the context. I think ideally we would instantiate a tracer per "sub"-service at startup and utilized that. (That would however require quite a bit of rework I fear) |
|
To be really useful with ocis theres also a small change required on the ocis side to initialize the DefaultTracerProvider: owncloud/ocis@master...rhafer:tracing |
butonic
approved these changes
Jun 15, 2022
40 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create separate TracerProviders per service to improve tracing when
running multiple services in a single process (like e.g. ocis does).
Previously all service were referring to the same package-level
TracerProvider (which, among other things, caused the services to
overwrite each others services names).
We still create a "global" TracerProvider to cover the cases where
we don't have access to the per service Provider yet. This will be
improved in a follow up change.