Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return codes on mkcol and put #3010

Merged
merged 11 commits into from
Jun 25, 2022
Merged

Fix return codes on mkcol and put #3010

merged 11 commits into from
Jun 25, 2022

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Jun 24, 2022

No description provided.

@butonic
return 404 when making mkcol to a non statable resource
33cbbd8 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
drop stat before file upload
c249874 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
return 404 when making PUT to a non statable resource
5c6c76c 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
return 404 when PROPPATCH removing a non statable resource
39c5a48 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
fix created flag
5a138a6 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic self-assigned this Jun 24, 2022
@butonic
update changelog
f8656a1 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the fix-return-codes-on-mkcol-and-put branch from 1d1171f to 1063d88 Compare June 24, 2022 11:36
@butonic
transport opaque in share up and downloads
1063d88 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
we actually expect to return 404
38c4774 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
return 403 when PUTing to readonly share
17c7561 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the fix-return-codes-on-mkcol-and-put branch from f9119c2 to aa1ccd6 Compare June 24, 2022 14:47
@butonic
fix integration and unit tests
aa1ccd6 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic marked this pull request as ready for review June 24, 2022 15:15
@butonic butonic requested review from a team, labkode, ishank011 and glpatcern as code owners June 24, 2022 15:15
@butonic
check parent on forbidden mkcol
1aaf40d 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
phil-davis
phil-davis approved these changes Jun 25, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Next week we can sort out the proper requirements for test scenarios 403 vs 404 vs 409 vx 4xx, and get the test suite expecting what is really required.

@butonic butonic merged commit 47ade51 into cs3org:edge Jun 25, 2022
@butonic butonic deleted the fix-return-codes-on-mkcol-and-put branch June 25, 2022 13:32
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@phil-davis phil-davis phil-davis approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees

@butonic butonic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@butonic @phil-davis @micbar