use Form instead of Query to also support application/x-www-form-urlencoded for the app provider http endpoint
#3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
…encoded` for the app provider http endpoint
wkloucek
requested review from
butonic,
kobergj,
rhafer and
dragonchaser
and removed request for
a team,
labkode,
glpatcern and
ishank011
glpatcern
approved these changes
Jul 22, 2022
Done in #3101 |
26 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: app provider http endpoint uses Form instead of Query
We've improved the http endpoint now uses the Form instead of Query
to also support
application/x-www-form-urlencodedparameters onthe app provider http endpoint.
The support for query parameter stays the same. See https://pkg.go.dev/net/http#Request.ParseForm. https://pkg.go.dev/net/url#URL.Query only parses the parameters from the URL