simplify gateway client usage #3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
force-pushed
the
ocdav-use-gwc-directly
branch
from
9721eac
to
6463144
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
commented
Nov 10, 2022
Comment on lines
-325
to
-328
| func (s *svc) getClient() (gateway.GatewayAPIClient, error) { | ||
| return s.gwClient, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
we never returned an error ... so getting rid of this
dragonchaser
approved these changes
Nov 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ocdav only fetches a gateway client once on startup we no longer need to check the error case whenever we call getClient() and can actually use the client of the service. Deleting all these unused error checks brings ocdav coverage from 9.8% to 10.1%
part of owncloud/ocis#5022