Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid user enumeration #2735

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Avoid user enumeration #2735

merged 3 commits into from
Apr 19, 2022

Conversation

kobergj
Copy link
Contributor

@kobergj kobergj commented Apr 12, 2022

Don't expose the altered requestPath to avoid user enumeration through PROPFIND requests.

Github-Issue: owncloud/ocis#3344
See also jira-ticket: https://jira.owncloud.com/browse/OCIS-2414

Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj requested review from a team, labkode and ishank011 as code owners April 12, 2022 08:08
@update-docs
Copy link

update-docs bot commented Apr 12, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kobergj kobergj requested review from C0rby and removed request for labkode and ishank011 April 12, 2022 08:08
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj requested a review from glpatcern as a code owner April 12, 2022 08:12
@kobergj kobergj changed the title Avoid user enmuration Avoid user enumeration Apr 12, 2022
@kobergj kobergj removed the request for review from glpatcern April 12, 2022 08:14
micbar
micbar previously approved these changes Apr 12, 2022
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj requested a review from micbar April 12, 2022 09:25
@kobergj
Copy link
Contributor Author

kobergj commented Apr 12, 2022

@micbar I needed to update expected failures as the tests were checking for exact error message. Could you recheck?

@kobergj kobergj dismissed micbar’s stale review April 12, 2022 12:52

later changes require re-review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants