get rid of public link url hash #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschade
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
fschade
force-pushed
the
public-link-hash
branch
from
a4a73fb
to
ea7b5d4
Compare
9 tasks
fschade
force-pushed
the
public-link-hash
branch
2 times, most recently
from
cc55fc6
to
6042f24
Compare
kulmann
approved these changes
Mar 1, 2022
fschade
force-pushed
the
public-link-hash
branch
from
1e91122
to
16ec8b8
Compare
fschade
force-pushed
the
public-link-hash
branch
from
16ec8b8
to
5779f5a
Compare
kulmann
reviewed
Mar 1, 2022
| @@ -212,7 +212,7 @@ func PublicShare2ShareData(share *link.PublicShare, r *http.Request, publicURL s | |||
| Token: share.Token, | |||
| Name: share.DisplayName, | |||
| MailSend: 0, | |||
| URL: publicURL + path.Join("/", "#/s/"+share.Token), | |||
| URL: publicURL + path.Join("/", "s/"+share.Token), | |||
There was a problem hiding this comment.
Suggested change
| URL: publicURL + path.Join("/", "s/"+share.Token), | |
| URL: publicURL + path.Join("/", "s", share.Token), |
?
There was a problem hiding this comment.
as discussed, this fails in CI and is not that important. keep it like it is.
ishank011
pushed a commit
to cernbox/reva
that referenced
this pull request
Mar 3, 2022
ishank011
pushed a commit
to cernbox/reva
that referenced
this pull request
Mar 3, 2022
26 tasks
ishank011
pushed a commit
to ishank011/reva
that referenced
this pull request
Mar 4, 2022
labkode
pushed a commit
that referenced
this pull request
Mar 7, 2022
ishank011
pushed a commit
to cernbox/reva
that referenced
this pull request
Mar 10, 2022
Daniel-WWU-IT
pushed a commit
to Daniel-WWU-IT/reva
that referenced
this pull request
Mar 16, 2022
Co-authored-by: Florian Schade <f.schade@icloud.com>
45 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of the public link url hash which is needed for web history mode.
owncloud/web#6363