Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge nextcloud-alpha into edge #2403

Merged
merged 9 commits into from
Jan 5, 2022
Merged

Merge nextcloud-alpha into edge #2403

merged 9 commits into from
Jan 5, 2022

Conversation

michielbdejong
Copy link
Contributor

No description provided.

@michielbdejong michielbdejong marked this pull request as draft December 28, 2021 16:14
@michielbdejong
Copy link
Contributor Author

I'll work out the hound errors and there are also a few tests that need to be adapted to recent evolution of the APIs between Reva and Nextcloud.

@lgtm-com
Copy link

lgtm-com bot commented Dec 28, 2021

This pull request introduces 3 alerts when merging dd3da06 into 06154a2 - view on LGTM.com

new alerts:

  • 3 for Missing error check

@butonic
Copy link
Contributor

butonic commented Jan 3, 2022

Happy new new year! @michielbdejong
Most of the ocis team is back from vacation, so ping us when you think this is ready. Looking forward to it!

@michielbdejong michielbdejong marked this pull request as ready for review January 5, 2022 15:45
@michielbdejong
Copy link
Contributor Author

@butonic Thanks! I think the tests are passing now (still waiting for a few unrelated integration tests to finish).

Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

@butonic butonic merged commit a1de3d0 into edge Jan 5, 2022
@butonic butonic deleted the nextcloud-alpha branch January 5, 2022 15:57
@michielbdejong
Copy link
Contributor Author

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants