Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load, dump and storageprovider fixes for migration #3171

Merged
merged 17 commits into from
Aug 31, 2022
Merged

load, dump and storageprovider fixes for migration #3171

merged 17 commits into from
Aug 31, 2022

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Aug 23, 2022

This PR

  • adds cs3 share manager Dump()
  • adds jsoncs3 share manager Load()
  • some sharemanager fixes to allow uploading a non existing file when an IfUnmodifiedSince header is set

@update-docs
Copy link

update-docs bot commented Aug 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic
load, dump and storageprovider fixes for migration
660e79e 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
jsoncs3 load testing
e4962dc 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
update unroutable shareids
eeab7b0 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
add some debug logs
141714d 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
Merge branch 'edge' into jsoncs3-load
be8a1ba
@butonic
add changelog
2527438 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested review from glpatcern and a team as code owners August 25, 2022 14:56
@butonic
use : as id delimiter
5088044 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic marked this pull request as draft August 26, 2022 11:56
@butonic
lint
bb1fd38 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
prevent panic
449144d 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic marked this pull request as ready for review August 26, 2022 15:00
kobergj
kobergj requested changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@kobergj kobergj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks as always...

internal/grpc/services/storageprovider/storageprovider.go Outdated Show resolved Hide resolved
pkg/share/manager/cs3/cs3.go Outdated Show resolved Hide resolved
pkg/share/manager/cs3/cs3.go Outdated Show resolved Hide resolved
pkg/share/manager/cs3/cs3.go Outdated Show resolved Hide resolved
pkg/share/manager/cs3/cs3.go Outdated Show resolved Hide resolved
pkg/share/manager/jsoncs3/jsoncs3.go Outdated Show resolved Hide resolved
pkg/share/manager/jsoncs3/jsoncs3.go Outdated Show resolved Hide resolved
pkg/share/manager/jsoncs3/jsoncs3_test.go Outdated Show resolved Hide resolved
pkg/share/manager/jsoncs3/shareid/shareid.go Show resolved Hide resolved
butonic and others added 7 commits August 30, 2022 13:04
@butonic
Apply some suggestions from code review
cf914f4
@butonic @kobergj
Update internal/grpc/services/storageprovider/storageprovider.go
4d6fcf1 
Co-authored-by: kobergj <juliankoberg@googlemail.com>
@butonic
extract method, drop implemented FIXME
747c361 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
extract validation functions
4cc9091 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
remove unnecessary mutex from Load()
65fe542 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
decrease log level to debug
8f991ef 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
prevent nil
dfe0a84 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested a review from kobergj August 30, 2022 15:05
kobergj
kobergj requested changes Aug 31, 2022
View reviewed changes
pkg/share/manager/cs3/cs3.go Outdated Show resolved Hide resolved
@butonic
use more ideomatic go error handling
f8df5bf 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested a review from kobergj August 31, 2022 08:36
kobergj
kobergj approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I like it 👍

@butonic butonic merged commit f4dd663 into cs3org:edge Aug 31, 2022
@butonic butonic deleted the jsoncs3-load branch August 31, 2022 10:30
@micbar micbar mentioned this pull request Sep 12, 2022
Closed
29 tasks
@aduffeck aduffeck mentioned this pull request Sep 12, 2022
Closed
3 tasks
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@butonic @kobergj