Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make less stat requests #3000

Merged
merged 7 commits into from
Jun 22, 2022
Merged

make less stat requests #3000

merged 7 commits into from
Jun 22, 2022

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Jun 22, 2022

Signed-off-by: Jörn Friedrich Dreyer jfd@butonic.de

@butonic butonic requested review from a team, labkode, ishank011 and glpatcern as code owners June 22, 2022 07:41
@butonic butonic force-pushed the less-stat-requests branch from 5813551 to ba7ce4a Compare June 22, 2022 07:45
C0rby
C0rby approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@butonic
make less stat requests
ba7ce4a 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
micbar
micbar approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

C0rby
C0rby suggested changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't comment all places where the code needs changes because it's pretty obvious.

internal/http/services/owncloud/ocdav/mkcol.go Show resolved Hide resolved
internal/http/services/owncloud/ocdav/mkcol.go Outdated Show resolved Hide resolved
internal/http/services/owncloud/ocdav/move.go Outdated Show resolved Hide resolved
internal/http/services/owncloud/ocdav/proppatch.go Outdated Show resolved Hide resolved
butonic added 2 commits June 22, 2022 08:54
@butonic
do not leak existence of resources if user cannot stat
bbb63a3 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
fix nil checks on space mkcol
4ea4a7c 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the less-stat-requests branch from 75b90ee to 4ea4a7c Compare June 22, 2022 09:12
butonic added 3 commits June 22, 2022 09:26
@butonic
fix proppatch response codes
2f13467 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
let MakeStorageSpaceReference actually return nil for invalid space id
02907f3 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
use error and avoid pointers
f308195 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
update expected failures
3758e35 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested a review from C0rby June 22, 2022 10:25
@C0rby C0rby merged commit cb6439c into cs3org:edge Jun 22, 2022
@butonic butonic deleted the less-stat-requests branch June 22, 2022 13:34
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@micbar micbar micbar approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@butonic @micbar @C0rby