fix spaces share jail usage #2904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
This was referenced May 31, 2022
butonic
force-pushed
the
share-jail-fixes
branch
6 times, most recently
from
e9bef9f
to
2b4c0ec
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
commented
Jun 2, 2022
internal/grpc/services/sharesstorageprovider/sharesstorageprovider_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
kobergj
previously requested changes
Jun 3, 2022
internal/grpc/services/sharesstorageprovider/sharesstorageprovider.go
Outdated
Show resolved
Hide resolved
internal/grpc/services/sharesstorageprovider/sharesstorageprovider.go
Outdated
Show resolved
Hide resolved
C0rby
reviewed
Jun 3, 2022
internal/grpc/services/sharesstorageprovider/sharesstorageprovider.go
Outdated
Show resolved
Hide resolved
internal/grpc/services/sharesstorageprovider/sharesstorageprovider.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
|
Kudos, SonarCloud Quality Gate passed!
|
C0rby
approved these changes
Jun 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing shares via the virtual share jail we now build correct relative references before forwarding the requests to the correct storage provider.
related: owncloud/ocis#3863
fixes owncloud/ocis#1787