implement listing shares in spaces #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
Instead of the query parameter `path` one can now send `space_ref` to list shares in spaces. The url would look like this: `https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares?reshares=true&space_ref=ae96eb17-1b37-4bfc-8ed6-9c044723a43f/elmo.gif`
wkloucek
reviewed
Mar 14, 2022
| @@ -34,7 +34,7 @@ cn="cn" | |||
| driver = "ldap" | |||
|
|
|||
| [grpc.services.userprovider.drivers.ldap] | |||
| hostname="ldap" | |||
| hostname="localhost" | |||
There was a problem hiding this comment.
that one shouldn't change?
There was a problem hiding this comment.
Why not? The toml files are for local integration tests. I don't have a container 'ldap' locally.
kobergj
requested changes
Mar 14, 2022
C0rby
force-pushed
the
sharing-in-spaces
branch
from
37a9b1d
to
a0d51eb
Compare
kobergj
approved these changes
Mar 15, 2022
22 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the query parameter
pathone can now sendspace_reftolist shares in spaces. The URL would look like this:
https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares?reshares=true&space_ref=ae96eb17-1b37-4bfc-8ed6-9c044723a43f/elmo.gifThe difference to the 'old' URL is the parameter
space_refinstead of thepathparameter.pathis always assumed to be relative to the users home andspace_refis the combined spaceid and the path relative to the space root.