Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share manager migration #2911

Merged
merged 16 commits into from
Jun 20, 2022
Merged

Share manager migration #2911

merged 16 commits into from
Jun 20, 2022

Conversation

aduffeck
Copy link
Contributor

@aduffeck aduffeck commented Jun 1, 2022

This PR introduces new interfaces for dumpable and loadable share managers and implements dumping shares from the json and loading dumps into cs3 manager.

@update-docs
Copy link

update-docs bot commented Jun 1, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@aduffeck aduffeck requested review from glpatcern and a team as code owners June 1, 2022 07:44
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic
Copy link
Contributor

butonic commented Jun 14, 2022

looking good! Is there a CLI to Load and Dump? I don't see where they are used beside the tests... Can you link to it?

@aduffeck
Copy link
Contributor Author

@butonic I have a branch which adds according migration commands to the ocis cli at https://github.com/aduffeck/ocis/commits/migrate-shares

Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli will come in a separate PR

@butonic butonic merged commit d834cf5 into cs3org:edge Jun 20, 2022
@butonic butonic deleted the share-manager-migration branch June 20, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants