Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locks mutexed #2582

Merged
merged 4 commits into from
Feb 24, 2022
Merged

Locks mutexed #2582

merged 4 commits into from
Feb 24, 2022

Conversation

dragotin
Copy link
Contributor

There must be only one Flock struct per lock file. If that
is existing, no other routine or process may get a lock.

@update-docs
Copy link

update-docs bot commented Feb 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though final word is for @butonic I guess. Will see if we can use (some of) this also in the EOS storage implementation, #2444

pkg/storage/utils/filelocks/filelocks.go Outdated Show resolved Hide resolved
pkg/storage/utils/filelocks/filelocks.go Outdated Show resolved Hide resolved
@dragotin dragotin requested a review from C0rby February 24, 2022 10:26
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

pkg/storage/utils/filelocks/filelocks.go Outdated Show resolved Hide resolved
There must be only one Flock struct per lock file. If that
is existing, no other routine or process may get a lock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants