Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quota calculation #2870

Merged
merged 3 commits into from
May 19, 2022
Merged

Conversation

butonic
Copy link
Contributor

@butonic butonic commented May 13, 2022

We now render the free and definition quota properties, taking into account the remaining bytes reported from the storage space and calculating relative only when possible.

Related: owncloud/ocis#3748

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested a review from kobergj May 17, 2022 13:24
rhafer
rhafer previously requested changes May 18, 2022
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Just some minor nitpicking.

And tests would be great 🙊

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic butonic requested a review from rhafer May 18, 2022 15:30
@butonic butonic self-assigned this May 19, 2022
@butonic butonic dismissed stale reviews from rhafer and kobergj May 19, 2022 11:36

addressed

Quota: &Quota{},
}
// TODO how do we fill lastlogin of a user when another user (with the necessary permissions) looks up the user?
// TODO someone needs to fill last-login
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 love the comment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants