-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quota calculation #2870
Merged
Merged
Update quota calculation #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
May 13, 2022 14:51
kobergj
previously requested changes
May 16, 2022
internal/http/services/owncloud/ocs/handlers/cloud/users/users.go
Outdated
Show resolved
Hide resolved
internal/http/services/owncloud/ocs/handlers/cloud/users/users.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
rhafer
previously requested changes
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me. Just some minor nitpicking.
And tests would be great 🙊
internal/http/services/owncloud/ocs/handlers/cloud/users/users.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Kudos, SonarCloud Quality Gate passed! |
kobergj
approved these changes
May 19, 2022
Quota: &Quota{}, | ||
} | ||
// TODO how do we fill lastlogin of a user when another user (with the necessary permissions) looks up the user? | ||
// TODO someone needs to fill last-login |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣 love the comment...
25 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now render the
free
anddefinition
quota properties, taking into account the remaining bytes reported from the storage space and calculatingrelative
only when possible.Related: owncloud/ocis#3748