Cs3 share manager #2626
Cs3 share manager #2626
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
aduffeck
force-pushed
the
cs3-share-manager
branch
from
aab0ac6 to
7bceda9
Compare
pkg/share/manager/cs3/cs3.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| fn := path.Join("shares", share.Id.OpaqueId) |
There was a problem hiding this comment.
I saw a few places where we hardcode path segments like this. I wonder if we should not have a central place where we define these instead of hardcoding.
Maybe not really part of this PR..
There was a problem hiding this comment.
@dragotin I just pushed a commit which changes the remaining places to also make use of shareFilename() which encapsulates the knowledge about the directoy layout.
Not sure if that's what you meant, but I don't think we need to move this to a central place inside the repository as the layout is only relevant to the share manager itself.
This PR introduces a new share manager which uses the new metadata storage backend.