fix propfinds with depth 0 #2918
Conversation
|
This approach omits stating the children and uses the virtual share jail as is. But the virtual share jail does not have a proper etag and mtime ... well, /dav/spaces/{sharejailid} now need to see all mountpoints as well, which means the share jail now has to calculate etag end mtime for the root anyway. So this might actually be the fix ... but for depth 0 we still need to aggregate the mtimes, size and use the most recent etag... |
Do you mean stating the children of the virtual share jail?
Isn't this happening here? reva/internal/http/services/owncloud/ocdav/propfind/propfind.go Lines 448 to 461 in 2c1792e |
|
I have now finally looked through the code again and I think that this is indeed the fix we need.
We are receiving all spaces, including the mountpoints, and are aggregating their sizes which then are added to the root. So nothing is omitted AFAIU. |
C0rby
force-pushed
the
depth-zero-propfind
branch
from
2c1792e
to
af05040
Compare
C0rby
force-pushed
the
depth-zero-propfind
branch
from
af05040
to
07b5963
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Oh wait, I still need to test this with subfolders. I only tested it with the root folder. |
This still worked. |
Fixed the response for propfinds with depth 0. The response now doesn't contain the shares jail anymore.
Fixes: owncloud/ocis#3704
@butonic, can you please double check that this is indeed the fix.