fix enforce-password issue for public links #3970
Conversation
2403905
force-pushed
the
issue-6476
branch
9 times, most recently
from
72e2b8a to
73c991e
Compare
2403905
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/public.go
Outdated
Show resolved
Hide resolved
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go
Outdated
Show resolved
Hide resolved
2403905
force-pushed
the
issue-6476
branch
5 times, most recently
from
c85aa21 to
5da1f57
Compare
2403905
force-pushed
the
issue-6476
branch
2 times, most recently
from
83abe2b to
7408189
Compare
| enforced = true | ||
| enforced = false |
There was a problem hiding this comment.
IMO this is fine. In reva we can run the CI with public.password enforcement off.
In ocis CI, in the future, we will be able to run with various "system parameter" settings, and can have test scenarios that check what happens when various public.password items are enforced.
There was a problem hiding this comment.
As I understand we can't use the env adjustments in the reva test. We have to cover the OCIS_SHARING_PUBLIC_WRITEABLE_SHARE_MUST_HAVE_PASSWORD configuration the ocis tests.
There was a problem hiding this comment.
Yes, we now have ways to reset env variables and restart ocis during tests on ocis. So we can do that sort of thing in ocis CI. We don't have any framework to do that is reva with toml files etc.
|
@2403905 is there an issue about this? |
2403905
force-pushed
the
issue-6476
branch
2 times, most recently
from
e04d671 to
c18cfa8
Compare
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/public.go
Outdated
Show resolved
Hide resolved
The related issue owncloud/ocis#6476 owncloud/ocis#6401