Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] API test for enforce password config and update the public share to edit permission #6409

Merged
merged 2 commits into from
Jun 22, 2023
Merged

[tests-only] [full-ci] API test for enforce password config and update the public share to edit permission #6409

merged 2 commits into from
Jun 22, 2023

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented May 30, 2023 •
edited
Loading

Description

This PR adds API test for setting the config OCIS_SHARING_PUBLIC_WRITEABLE_SHARE_MUST_HAVE_PASSWORD to true and update the public share to edit permission.

Related Issue

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya self-assigned this May 30, 2023
@PrajwolAmatya PrajwolAmatya mentioned this pull request May 30, 2023
Closed
5 tasks
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review May 30, 2023 09:52
@PrajwolAmatya PrajwolAmatya force-pushed the test-using-ocis-env branch from 152b8aa to c81d260 Compare May 30, 2023 09:55
@PrajwolAmatya PrajwolAmatya force-pushed the test-using-ocis-env branch from c81d260 to 6cb1d77 Compare May 31, 2023 03:30
@PrajwolAmatya PrajwolAmatya force-pushed the test-using-ocis-env branch from 6cb1d77 to c6b9adf Compare May 31, 2023 05:08
@PrajwolAmatya PrajwolAmatya force-pushed the test-using-ocis-env branch from c6b9adf to 7350bf2 Compare June 2, 2023 07:34
@PrajwolAmatya PrajwolAmatya force-pushed the test-using-ocis-env branch from 7350bf2 to a7bd93c Compare June 7, 2023 08:42
@PrajwolAmatya PrajwolAmatya changed the title [tests-only] [full-ci] API test for enforce password for public link [tests-only] [full-ci] API test for enforce password config and update the public share to edit permission Jun 7, 2023
@PrajwolAmatya PrajwolAmatya force-pushed the test-using-ocis-env branch 3 times, most recently from 04a10db to 24f36bc Compare June 14, 2023 08:44
saw-jan
saw-jan reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should wait for the fix: #6476

tests/acceptance/features/apiGraph/enforcePasswordPublicLink.feature Outdated Show resolved Hide resolved
@2403905 2403905 mentioned this pull request Jun 20, 2023
Closed
@2403905
Copy link
Contributor

2403905 commented Jun 20, 2023

@PrajwolAmatya @saw-jan I already finished the enforce password in a reva backend for the create /update actions #6476 . Before we merge and bump the reva we have to update the tests.
Now I see a lot of failed scenarios.

make test-acceptance-from-core-api \
TEST_SERVER_URL=https://localhost:9200 \
TEST_WITH_GRAPH_API=true \
TEST_OCIS=true \
BEHAT_FEATURE=tests/acceptance/features/coreApiSharePublicLink3/updatePublicLinkShare.feature

.....

46 scenarios (32 passed, 14 failed)
502 steps (447 passed, 14 failed, 41 skipped)
0m48.40s (17.74Mb)
grep: empty (sub)expression
grep: empty (sub)expression

The following tests were skipped because they are tagged @skip:
runsh: Total 0 scenarios (0 passed, 0 failed)
runsh: Total unexpected failed scenarios throughout the test run:
coreApiSharePublicLink3/updatePublicLinkShare.feature:182
coreApiSharePublicLink3/updatePublicLinkShare.feature:183
coreApiSharePublicLink3/updatePublicLinkShare.feature:214
coreApiSharePublicLink3/updatePublicLinkShare.feature:215
coreApiSharePublicLink3/updatePublicLinkShare.feature:246
coreApiSharePublicLink3/updatePublicLinkShare.feature:247
coreApiSharePublicLink3/updatePublicLinkShare.feature:288
coreApiSharePublicLink3/updatePublicLinkShare.feature:289
coreApiSharePublicLink3/updatePublicLinkShare.feature:330
coreApiSharePublicLink3/updatePublicLinkShare.feature:331
coreApiSharePublicLink3/updatePublicLinkShare.feature:352
coreApiSharePublicLink3/updatePublicLinkShare.feature:353
coreApiSharePublicLink3/updatePublicLinkShare.feature:374
coreApiSharePublicLink3/updatePublicLinkShare.feature:375

@2403905
Copy link
Contributor

2403905 commented Jun 20, 2023

@PrajwolAmatya @saw-jan The ocis tests are green for #6476 #6564

@saw-jan
Copy link
Member

saw-jan commented Jun 21, 2023 •
edited
Loading

@PrajwolAmatya @saw-jan The ocis tests are green for #6476 #6564

So now, reva PR (cs3org/reva#3970) should be merged and bumped reva in ocis and then we can change the expected statuscode in this PR then merge.

Or @2403905 you can bump reva here directly

@PrajwolAmatya PrajwolAmatya requested a review from SagarGi June 22, 2023 05:28
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SwikritiT
SwikritiT approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SwikritiT SwikritiT merged commit 831d57f into master Jun 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the test-using-ocis-env branch June 22, 2023 08:40
ownclouders pushed a commit that referenced this pull request Jun 22, 2023
@PrajwolAmatya
[tests-only] [full-ci] API test for enforce password config and updat…
ed2f54f 
…e the public share to edit permission (#6409)

* api test to update public link to upload, edit or contribute permission with enforce password enabled

* added test to create public link with enforce password enabled
@PrajwolAmatya PrajwolAmatya mentioned this pull request Jun 22, 2023
Merged
9 tasks
fschade pushed a commit that referenced this pull request Jul 10, 2023
@PrajwolAmatya @fschade
[tests-only] [full-ci] API test for enforce password config and updat…
d440078 
…e the public share to edit permission (#6409)

* api test to update public link to upload, edit or contribute permission with enforce password enabled

* added test to create public link with enforce password enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT SwikritiT approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PrajwolAmatya @2403905 @saw-jan @SwikritiT @SagarGi @amrita-shrestha