Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Backport enforce password test scenarios #6598

Merged
merged 2 commits into from
Jun 23, 2023
Merged

[tests-only][full-ci] Backport enforce password test scenarios #6598

merged 2 commits into from
Jun 23, 2023

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Jun 22, 2023 •
edited
Loading

Description

This PR backports PR #6409

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya self-assigned this Jun 22, 2023
@PrajwolAmatya PrajwolAmatya mentioned this pull request Jun 22, 2023
Merged
10 tasks
SwikritiT
SwikritiT approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is also happy

@saw-jan
Copy link
Member

saw-jan commented Jun 22, 2023

Fix not in the stable-3.0. So, we can skip with tag (@SagarGi knows the tag)

runsh: Total unexpected failed scenarios throughout the test run:
apiGraph/enforcePasswordPublicLink.feature:25
apiGraph/enforcePasswordPublicLink.feature:26
apiGraph/enforcePasswordPublicLink.feature:41
apiGraph/enforcePasswordPublicLink.feature:42

@PrajwolAmatya PrajwolAmatya force-pushed the backport-enforce-password-test-scenarios branch from adcc8ba to b54dbac Compare June 23, 2023 03:26
SagarGi
SagarGi reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy

@PrajwolAmatya PrajwolAmatya force-pushed the backport-enforce-password-test-scenarios branch from b54dbac to 2bcf371 Compare June 23, 2023 04:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@PrajwolAmatya PrajwolAmatya merged commit 247615c into stable-3.0 Jun 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the backport-enforce-password-test-scenarios branch June 23, 2023 05:37
ownclouders pushed a commit that referenced this pull request Jun 23, 2023
@PrajwolAmatya
[tests-only][full-ci] Backport enforce password test scenarios (#6598)
4533e2a 
* api test to update public link to upload, edit or contribute permission with enforce password enabled

* added test to create public link with enforce password enabled
ownclouders pushed a commit that referenced this pull request Jun 24, 2023
@PrajwolAmatya
[tests-only][full-ci] Backport enforce password test scenarios (#6598)
044dff2 
* api test to update public link to upload, edit or contribute permission with enforce password enabled

* added test to create public link with enforce password enabled
ownclouders pushed a commit that referenced this pull request Jun 25, 2023
@PrajwolAmatya
[tests-only][full-ci] Backport enforce password test scenarios (#6598)
43ed729 
* api test to update public link to upload, edit or contribute permission with enforce password enabled

* added test to create public link with enforce password enabled
ownclouders pushed a commit that referenced this pull request Jun 26, 2023
@PrajwolAmatya
[tests-only][full-ci] Backport enforce password test scenarios (#6598)
009cb35 
* api test to update public link to upload, edit or contribute permission with enforce password enabled

* added test to create public link with enforce password enabled
ownclouders pushed a commit that referenced this pull request Jun 27, 2023
@PrajwolAmatya
[tests-only][full-ci] Backport enforce password test scenarios (#6598)
a6a872d 
* api test to update public link to upload, edit or contribute permission with enforce password enabled

* added test to create public link with enforce password enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT SwikritiT approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PrajwolAmatya @saw-jan @SwikritiT @SagarGi