Set mtime to storage after simple upload #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 10, 2020 14:38
When using Webdav PUT, if the header X-OC-Mtime is specified, pass it on to the storage as an arbitrary metadata.
When uploading with TUS POST using the creation-with-upload extension without chunking, apply the mtime to the storage.
2 tasks
labkode
approved these changes
Jun 10, 2020
C0rby
pushed a commit
to owncloud/reva
that referenced
this pull request
Jun 30, 2020
* Set mtime during upload on direct PUT When using Webdav PUT, if the header X-OC-Mtime is specified, pass it on to the storage as an arbitrary metadata. * Set mtime for TUS direct single shot uploads When uploading with TUS POST using the creation-with-upload extension without chunking, apply the mtime to the storage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the chunking scenario it will be more tricky as we need to pass in the mtime through InitiateFileUpload, to be researched separately.
Part of owncloud/ocis-reva#174
Tested Webdav PUT with Phoenix by starting OCIS with
REVA_FRONTEND_UPLOAD_DISABLE_TUS=trueTested TUS POST using Phoenix PR for creation-with-upload: owncloud/web#3436
in both case, I checked that the timestamp reported by Phoenix was not "a few seconds ago"
@butonic FYI