Preserve mtime after TUS upload

[PVince81]

For a PUT request it was always possible to pass in a header "X-OC-Mtime" to specify the mtime of the uploaded file.

Since the addition of TUS upload, Phoenix is already sending the mtime in the Upload-Metadata metadata, but that value is not passed along.

• pass along X-OC-Mtime mtime value to storage's TUS metadata: https://github.com/cs3org/reva/blob/master/internal/http/services/owncloud/ocdav/put.go#L257
• tus.go must also honor the "mtime" metadata and pass it along to the storage: https://github.com/cs3org/reva/blob/master/internal/http/services/owncloud/ocdav/tus.go#L56

Now I'm not sure whether we store it as "arbitrary metadata" there or whether there is another way streamlined with the storage (like touch)

@butonic

[butonic]

Just Touch the file. eos uses the inode and mtime to calculate the etag (but the etag can also be set, so restoring backups works without changing all etags).
x-oc-mtime should affect the mtime

the owncloud storage driver implments setting arbitrary metadata and touches the file when mtime is set

the eos driver currently does not support setting arbitrary metadata ... 😞
the eosclient does have a Touch, but has no time parameter

[PVince81]

the eos driver currently does not support setting arbitrary metadata

raised here: https://github.com/owncloud/ocis-reva/issues/189

[PVince81]

I've added to the MVP project as mtime preservation was already on the roadmap

[PVince81]

• BUG: to investigate: even a regular Webdav PUT is not preserving the mtime even though it's returning "X-OC-Mtime: accepted" => fixed through Set mtime to storage after simple upload cs3org/reva#823

[PVince81]

PR for the non-chunked scenarios: cs3org/reva#823

[PVince81]

Raised #273 for adding related API test

[PVince81]

PR for propagating mtime in chunked mode: cs3org/reva#841

[PVince81]

• enable test

[individual-it]

@PVince81 this is closed but tests are not enabled yet. reopen, or is there an other ticket?

[PVince81]

• PRs for tests:
  • [Tests-Only] Added API test for public link Mtime core#37589
  • [Tests-Only] Added API test for public link Mtime core#37589

[individual-it]

the PR you have mentioned is only for the public link upload, for normal upload the PRs are
owncloud/core#37553
owncloud/core#37607

[PVince81]

this is the actual ticket: #273