[Tests-Only] Added API test for public link Mtime #37589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
individual-it
requested changes
Jun 24, 2020
There was a problem hiding this comment.
please add tests:
- check the mtime if the share is a share of a folder and not a file
- upload as public with a historic mtime (share is a file or folder, different permissions (e.g. upload only, upload and read) - check that the mtime is reported correctly through the webdav interface of the user
- upload as public overwriting an existing file and setting the mtime
tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #37589 +/- ##
=========================================
Coverage 64.71% 64.71%
Complexity 19359 19359
=========================================
Files 1281 1281
Lines 75637 75637
Branches 1333 1333
=========================================
Hits 48949 48949
Misses 26296 26296
Partials 392 392
Continue to review full report at Codecov.
|
Talank
force-pushed
the
public-link-mtime
branch
from
a0ed56e to
b0ae828
Compare
2 tasks
|
fix was added in owncloud/web#3686 (review) |
phil-davis
reviewed
Jun 29, 2020
tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature
Outdated
Show resolved
Hide resolved
|
code-style problem always good to run |
individual-it
requested changes
Jun 30, 2020
individual-it
requested changes
Jun 30, 2020
| And the mtime of file "file.txt" in the last shared public link using the WebDAV API should be "Thu, 08 Aug 2019 04:18:13 GMT" | ||
|
|
||
| @issue-ocis-reva-49 @issue-37605 | ||
| Scenario: Get the mtime of a file inside a folder shared by public link using old dav version |
There was a problem hiding this comment.
old or new? the test says "new"
Talank
force-pushed
the
public-link-mtime
branch
4 times, most recently
from
e88d8a6 to
e394902
Compare
individual-it
requested changes
Jul 1, 2020
| $mtime = \implode(" ", $mtime); | ||
| Assert::assertContains( | ||
| $mtime, | ||
| (new TestHelpers\WebDavHelper)->getMtimeOfFileinPublicLinkShare($baseUrl, $fileName, $token) |
There was a problem hiding this comment.
why do we need that construct?
shouldn't \TestHelpers\WebDavHelper::getMtimeOfFileinPublicLinkShare($baseUrl, $fileName, $token) work? The functions in the TestHelpers should all be static
individual-it
requested changes
Jul 1, 2020
tests/TestHelpers/WebDavHelper.php
Outdated
| * @return string | ||
| * @throws Exception | ||
| */ | ||
| public function getMtimeOfFileinPublicLinkShare( |
There was a problem hiding this comment.
make the function static like all others
| | permissions | read,update,create,delete | | ||
| When the public uploads file "file.txt" to the last shared folder with mtime "Thu, 08 Aug 2019 04:18:13 GMT" using the new public WebDAV API | ||
| Then as "Alice" file "testFolder/file.txt" should exist | ||
| And the mtime of file "file.txt" in the last shared public link using the WebDAV API should not be "Thu, 08 Aug 2019 04:18:13 GMT" |
There was a problem hiding this comment.
check the mtime also through the "normal" webDAV api
individual-it
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
API Acceptance test for public link mtime is added
Related Issue
Fixes owncloud/ocis-reva#296
How Has This Been Tested?
Types of changes
Checklist: