Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UID and GID to the user object from EOS fs #995

Merged
merged 15 commits into from
Jul 28, 2020

Conversation

ishank011
Copy link
Contributor

This is an alternative approach to #983 where the gateway is available to EOS fs, from where it can resolve UIDs back to users, instead of passing it to the gateway layers.

@ishank011 ishank011 requested a review from labkode as a code owner July 23, 2020 10:16
@ishank011 ishank011 requested review from butonic, IljaN and refs July 23, 2020 10:17
pkg/user/user.go Outdated Show resolved Hide resolved
internal/grpc/services/userprovider/userprovider.go Outdated Show resolved Hide resolved
@labkode
Copy link
Member

labkode commented Jul 24, 2020

@butonic we'll introduce a new call in the CS3APIS to getUsers by arbitrary claims, like uid or usernames (for those who use them).

@ishank011
Copy link
Contributor Author

@labkode made the change. Please take a look.

@labkode labkode self-requested a review July 28, 2020 13:56
@kulmann kulmann mentioned this pull request Aug 7, 2020
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants