Skip to content

Compatibility issue with Expo 44 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mcchrish opened this issue Jan 4, 2022 · 3 comments
Open

Compatibility issue with Expo 44 #40

mcchrish opened this issue Jan 4, 2022 · 3 comments
Assignees
@prometheas
Labels
bug Something isn't working

Comments

@mcchrish
Copy link

mcchrish commented Jan 4, 2022

Fix: expo/expo#15622 (comment)
@prometheas prometheas mentioned this issue Jan 19, 2022
Closed
@prometheas
Copy link
Collaborator

Hey @mcchrish. Hope this doesn't feel to "spammy", but I posted a pseudo-issue about exploring a community fork in #41, in case you'd be interested.

@prometheas
Copy link
Collaborator

Follow-up here, @mcchrish - the original author has kindly added me as a maintainer for the project. I shared some important notes about this on my closing comment for #41, if you're interested.

But I wanted to let you know that I'm able to accept PRs to this project moving forward, for what it's worth.

@prometheas prometheas self-assigned this Feb 2, 2022
@prometheas prometheas added the bug Something isn't working label Feb 2, 2022
@prometheas
Copy link
Collaborator

Mentioning, for record-keeping purposes, that I've pinged the Expo team about confirming the proposed fix, along with the amended minimum React Native version necessary to incorporate that fix.

@prometheas prometheas mentioned this issue Feb 2, 2022
Closed
prometheas added a commit that referenced this issue Feb 17, 2022
@prometheas
fix: address Expo 44 incompatibility
c9c77ee 
This fix for issue #40 makes the package compatible with Expo SDK 44+, but breaks backward compatibility with React Native versions less than 0.61.

BREAKING CHANGES
@prometheas prometheas mentioned this issue Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prometheas prometheas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prometheas @mcchrish