fix: address Expo 44 incompatibility #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix for issue #40 makes the package compatible with Expo SDK 44+, but breaks backward compatibility with React Native versions less than 0.61. BREAKING CHANGES
|
I recognize that neither @csath nor @tautvilas might have the time, bandwidth, or inclination to review this PR, but I thought I'd give someone not-me an opportunity to weigh in before merging to Will merge without feedback if nobody is able to review by Monday (21 Feb). |
|
After some smoke testing of this update in an app I'm working on, and after no explicit feedback since February of this year, I'm going to proceed with the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix for issue #40 makes the package compatible with Expo SDK 44+, but breaks backward compatibility with React Native versions less than 0.61.
BREAKING CHANGES