fix: Render LIMIT 0 and OFFSET 0 properly in SQL templates #8781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8781 +/- ##
=======================================
Coverage 82.67% 82.68%
=======================================
Files 219 219
Lines 78127 78161 +34
=======================================
+ Hits 64589 64624 +35
+ Misses 13538 13537 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mcheshkov
force-pushed
the
sql-api-limit-template
branch
from
7cb9cc5
to
b5a85d6
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
mcheshkov
force-pushed
the
sql-api-limit-template
branch
2 times, most recently
from
bd23c96
to
da70a8e
Compare
srh
approved these changes
Oct 4, 2024
mcheshkov
force-pushed
the
sql-api-limit-template
branch
2 times, most recently
from
a973ce4
to
7f8e091
Compare
ovr
approved these changes
Oct 9, 2024
`if limit` condition in Jinja will fail for both None and Some(0) This is more or less fine for offset, but completely wrong for limit. For consistency both are changed. Also add unit test in SQL API and smoke E2E test
mcheshkov
force-pushed
the
sql-api-limit-template
branch
from
7f8e091
to
4e1ca10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
if limitcondition in Jinja will fail for bothNoneandSome(0)This is more or less fine for offset, but completely wrong for limit. For consistency both are changed.