Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cubesql): Extract CubeScanWrappedSqlNode from CubeScanWrapperNode #8786

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 89.15663% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.62%. Comparing base (5fd13d1) to head (7846a90).

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/mod.rs 89.28% 6 Missing ⚠️
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 66.66% 4 Missing ⚠️
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 92.00% 4 Missing ⚠️
...t/cubesql/cubesql/src/compile/test/test_wrapper.rs 92.85% 3 Missing ⚠️
rust/cubesql/cubesql/src/compile/test/utils.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8786      +/-   ##
==========================================
- Coverage   82.66%   82.62%   -0.04%     
==========================================
  Files         221      221              
  Lines       78303    78100     -203     
==========================================
- Hits        64726    64533     -193     
+ Misses      13577    13567      -10     
Flag Coverage Δ
cubesql 82.62% <89.15%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov force-pushed the split-wrapper-and-wrapped branch 3 times, most recently from 1a80430 to 1681451 Compare October 9, 2024 18:41
@mcheshkov mcheshkov force-pushed the split-wrapper-and-wrapped branch 3 times, most recently from 42a8b61 to 3b60567 Compare October 17, 2024 16:15
@mcheshkov mcheshkov force-pushed the split-wrapper-and-wrapped branch 4 times, most recently from 78f3fda to 320990b Compare October 22, 2024 17:00
@mcheshkov mcheshkov marked this pull request as ready for review November 13, 2024 13:17
@mcheshkov mcheshkov requested a review from a team as a code owner November 13, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant