Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial support for grouped join pushdown #9032

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

[Description goes here]

They would be used later as a way to allow replacers to handle column from grouped subquery in join
Non-flatten rules will gain support for joins with grouped-grouped joins SQL generation support in WrappedSelect
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 94.06911% with 115 lines in your changes missing coverage. Please review.

Project coverage is 83.05%. Comparing base (dcc46c7) to head (26820f6).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 85.20% 50 Missing ⚠️
.../src/models/v1_load_request_query_join_subquery.rs 0.00% 14 Missing ⚠️
...c/compile/rewrite/rules/wrapper/scalar_function.rs 78.78% 7 Missing ⚠️
rust/cubesql/cubesql/src/compile/mod.rs 89.47% 6 Missing ⚠️
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 66.66% 4 Missing ⚠️
...ubesql/src/compile/rewrite/rules/wrapper/column.rs 95.12% 4 Missing ⚠️
.../cubesql/src/compile/rewrite/rules/wrapper/join.rs 98.87% 4 Missing ⚠️
...sql/src/compile/rewrite/rules/wrapper/aggregate.rs 97.72% 3 Missing ⚠️
...l/cubesql/src/compile/rewrite/rules/wrapper/mod.rs 95.38% 3 Missing ⚠️
...t/cubesql/cubesql/src/compile/test/test_wrapper.rs 94.11% 3 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9032      +/-   ##
==========================================
+ Coverage   82.78%   83.05%   +0.26%     
==========================================
  Files         221      224       +3     
  Lines       78494    79810    +1316     
==========================================
+ Hits        64979    66283    +1304     
- Misses      13515    13527      +12     
Flag Coverage Δ
cubesql 83.05% <94.06%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review December 10, 2024 20:39
@mcheshkov mcheshkov requested review from a team as code owners December 10, 2024 20:39
@mcheshkov mcheshkov requested a review from a team as a code owner December 10, 2024 20:39
@mcheshkov mcheshkov changed the title feast: Initial support for grouped join pushdown feat: Initial support for grouped join pushdown Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant