Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cubesql): Extract CubeScanWrappedSqlNode from CubeScanWrapperNode #8786

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

refactor(cubesql): Extract CubeScanWrappedSqlNode from CubeScanWrappe…

7846a90
Select commit
Loading
Failed to load commit list.
Open

refactor(cubesql): Extract CubeScanWrappedSqlNode from CubeScanWrapperNode #8786

refactor(cubesql): Extract CubeScanWrappedSqlNode from CubeScanWrappe…
7846a90
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 13, 2024 in 0s

82.62% (-0.04%) compared to 5fd13d1

View this Pull Request on Codecov

82.62% (-0.04%) compared to 5fd13d1

Details

Codecov Report

Attention: Patch coverage is 89.15663% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.62%. Comparing base (5fd13d1) to head (7846a90).

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/mod.rs 89.28% 6 Missing ⚠️
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 66.66% 4 Missing ⚠️
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 92.00% 4 Missing ⚠️
...t/cubesql/cubesql/src/compile/test/test_wrapper.rs 92.85% 3 Missing ⚠️
rust/cubesql/cubesql/src/compile/test/utils.rs 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8786      +/-   ##
==========================================
- Coverage   82.66%   82.62%   -0.04%     
==========================================
  Files         221      221              
  Lines       78303    78100     -203     
==========================================
- Hits        64726    64533     -193     
+ Misses      13577    13567      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov