Remove message-streams from the monorepo (#1927)

* Remove message-streams from the monorepo * Update gherkin changelog to document the removal of message-streams from its dependencies
cucumber · Mar 23, 2022 · 9f38269 · 9f38269
1 parent 3a8980e
commit 9f38269
Show file tree

Hide file tree

Showing 35 changed files with 518 additions and 1,321 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -141,18 +141,6 @@ jobs:
 
  ### JavaScript
 
- message-streams-javascript:
- executor: docker-circleci-node-14
- steps:
- - attach_workspace:
- at: '~/cucumber'
- - run:
- name: message-streams/javascript
- command: |
- sudo npm install --global npm@7
- cd message-streams/javascript
- make
-
  messages-javascript:
  executor: docker-circleci-node-14
  steps:
@@ -650,9 +638,6 @@ workflows:
 
  ### JavaScript
 
- - message-streams-javascript:
- requires:
- - prepare-parallel
  - messages-javascript:
  requires:
  - prepare-parallel

diff --git a/Makefile b/Makefile
@@ -1,7 +1,6 @@
 SHELL := /usr/bin/env bash
 BUILD_IMAGE ?= $(shell grep "image: cucumber/cucumber-build:" .circleci/config.yml | cut -c 16-)
 PACKAGES ?= messages \
- message-streams \
  gherkin \
  gherkin-utils \
  fake-cucumber \

diff --git a/compatibility-kit/javascript/package.json b/compatibility-kit/javascript/package.json
@@ -18,5 +18,8 @@
  "@types/stream-buffers": "3.0.4",
  "stream-buffers": "3.0.2",
  "typescript": "4.6.2"
+ },
+ "dependencies": {
+ "@cucumber/message-streams": "^4.0.0"
  }
 }
diff --git a/fake-cucumber/javascript/package.json b/fake-cucumber/javascript/package.json
@@ -46,7 +46,7 @@
  "@cucumber/gherkin-streams": "^5.0.0",
  "@cucumber/gherkin-utils": "^7.0.0",
  "@cucumber/messages": "^17.1.1",
- "@cucumber/message-streams": "^3.0.0",
+ "@cucumber/message-streams": "^4.0.0",
  "@cucumber/tag-expressions": "^4.1.0",
  "@types/stack-utils": "2.0.1",
  "commander": "9.1.0",

diff --git a/gherkin-utils/javascript/package.json b/gherkin-utils/javascript/package.json
@@ -27,7 +27,7 @@
  "devDependencies": {
  "@cucumber/gherkin": "^22.0.0",
  "@cucumber/gherkin-streams": "^5.0.0",
- "@cucumber/message-streams": "^3.0.0",
+ "@cucumber/message-streams": "^4.0.0",
  "@types/mocha": "9.1.0",
  "@types/node": "16.11.26",
  "fast-glob": "3.2.11",

diff --git a/gherkin/CHANGELOG.md b/gherkin/CHANGELOG.md
@@ -17,6 +17,9 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
 * [Java] Made all internal classes package private
 * [Java] Removed unused `stopAtFirstError` property from `Parser`
 * [PHP] Implemented `Gherkin`
+* [JavaScript] `@cucumber/message-streams` has been removed from the dependencies.
+ If you are using `@cucumber/gherkin-streams` v5.0.0 or later, you have to add
+ `@cucumber/message-streams` in your dependencies in addition to `@cucumber/gherkin`.
 
 ### Deprecated
 

diff --git a/gherkin/javascript/package.json b/gherkin/javascript/package.json
@@ -32,7 +32,6 @@
  "typescript": "4.6.2"
  },
  "dependencies": {
- "@cucumber/message-streams": "^3.0.0",
  "@cucumber/messages": "^17.1.1"
  },
  "directories": {

diff --git a/json-to-messages/javascript/package.json b/json-to-messages/javascript/package.json
@@ -40,7 +40,7 @@
  "@cucumber/gherkin-streams": "^5.0.0",
  "@cucumber/gherkin-utils": "^7.0.0",
  "@cucumber/messages": "^17.1.1",
- "@cucumber/message-streams": "^3.0.0",
+ "@cucumber/message-streams": "^4.0.0",
  "commander": "9.1.0",
  "glob": "7.2.0",
  "source-map-support": "0.5.21"

diff --git a/message-streams/.rsync b/message-streams/.rsync
diff --git a/message-streams/CHANGELOG.md b/message-streams/CHANGELOG.md
diff --git a/message-streams/Makefile b/message-streams/Makefile
diff --git a/message-streams/README.md b/message-streams/README.md
diff --git a/message-streams/default.mk b/message-streams/default.mk
diff --git a/message-streams/javascript/.gitignore b/message-streams/javascript/.gitignore
diff --git a/message-streams/javascript/.mocharc.json b/message-streams/javascript/.mocharc.json
diff --git a/message-streams/javascript/.rsync b/message-streams/javascript/.rsync
diff --git a/message-streams/javascript/Makefile b/message-streams/javascript/Makefile
diff --git a/message-streams/javascript/README.md b/message-streams/javascript/README.md
diff --git a/message-streams/javascript/default.mk b/message-streams/javascript/default.mk
diff --git a/message-streams/javascript/package.cjs.json b/message-streams/javascript/package.cjs.json