Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove message-streams from the monorepo #1927

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Conversation

aurelien-reeves
Copy link
Contributor

Summary

message-streams now lives in its own repo here: https://github.com/cucumber/message-streams/

Motivation and Context

Refs. #1724

How Has This Been Tested?

Thanks to the CI

@aurelien-reeves aurelien-reeves marked this pull request as draft March 21, 2022 09:59
@aurelien-reeves aurelien-reeves marked this pull request as ready for review March 21, 2022 10:24
@aurelien-reeves
Copy link
Contributor Author

Reviewers: I would like to draw your attention on the gherkin changelog, as there may be kinda undesired changed with gherkin-streams

Copy link
Contributor

@davidjgoss davidjgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewers: I would like to draw your attention on the gherkin changelog, as there may be kinda undesired changed with gherkin-streams

This seems like the right change to me. gherkin-streams lists message-streams as a peer dependency so it's expressed correctly - although I do think we should add an Installation section to the readme there and explicitly call out the peer dependencies.

Also I think the plan is for gherkin to be decoupled from messages, right? So this should be short-lived anyway.

@aurelien-reeves
Copy link
Contributor Author

although I do think we should add an Installation section to the readme there and explicitly call out the peer dependencies.

You mean, the Installation section of gherkin-streams?

@davidjgoss
Copy link
Contributor

although I do think we should add an Installation section to the readme there and explicitly call out the peer dependencies.

You mean, the Installation section of gherkin-streams?

Sorry - yes exactly.

@aurelien-reeves
Copy link
Contributor Author

@davidjgoss something like that: cucumber/gherkin-streams#12?

@aurelien-reeves aurelien-reeves enabled auto-merge (squash) March 23, 2022 08:50
@aurelien-reeves aurelien-reeves merged commit 9f38269 into main Mar 23, 2022
@aurelien-reeves aurelien-reeves deleted the remove-message-streams branch March 23, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants