Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove message-streams from the monorepo #1927

Merged
merged 3 commits into from
Mar 23, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -141,18 +141,6 @@ jobs:

### JavaScript

message-streams-javascript:
executor: docker-circleci-node-14
steps:
- attach_workspace:
at: '~/cucumber'
- run:
name: message-streams/javascript
command: |
sudo npm install --global npm@7
cd message-streams/javascript
make

messages-javascript:
executor: docker-circleci-node-14
steps:
Expand Down Expand Up @@ -650,9 +638,6 @@ workflows:

### JavaScript

- message-streams-javascript:
requires:
- prepare-parallel
- messages-javascript:
requires:
- prepare-parallel
Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
SHELL := /usr/bin/env bash
BUILD_IMAGE ?= $(shell grep "image: cucumber/cucumber-build:" .circleci/config.yml | cut -c 16-)
PACKAGES ?= messages \
message-streams \
gherkin \
gherkin-utils \
fake-cucumber \
Expand Down
3 changes: 3 additions & 0 deletions compatibility-kit/javascript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,8 @@
"@types/stream-buffers": "3.0.4",
"stream-buffers": "3.0.2",
"typescript": "4.6.2"
},
"dependencies": {
"@cucumber/message-streams": "^4.0.0"
}
}
2 changes: 1 addition & 1 deletion fake-cucumber/javascript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"@cucumber/gherkin-streams": "^5.0.0",
"@cucumber/gherkin-utils": "^7.0.0",
"@cucumber/messages": "^17.1.1",
"@cucumber/message-streams": "^3.0.0",
"@cucumber/message-streams": "^4.0.0",
"@cucumber/tag-expressions": "^4.1.0",
"@types/stack-utils": "2.0.1",
"commander": "9.1.0",
Expand Down
2 changes: 1 addition & 1 deletion gherkin-utils/javascript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"devDependencies": {
"@cucumber/gherkin": "^22.0.0",
"@cucumber/gherkin-streams": "^5.0.0",
"@cucumber/message-streams": "^3.0.0",
"@cucumber/message-streams": "^4.0.0",
"@types/mocha": "9.1.0",
"@types/node": "16.11.26",
"fast-glob": "3.2.11",
Expand Down
3 changes: 3 additions & 0 deletions gherkin/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
* [Java] Made all internal classes package private
* [Java] Removed unused `stopAtFirstError` property from `Parser`
* [PHP] Implemented `Gherkin`
* [JavaScript] `@cucumber/message-streams` has been removed from the dependencies.
If you are using `@cucumber/gherkin-streams` v5.0.0 or later, you have to add
`@cucumber/message-streams` in your dependencies in addition to `@cucumber/gherkin`.

### Deprecated

Expand Down
1 change: 0 additions & 1 deletion gherkin/javascript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
"typescript": "4.6.2"
},
"dependencies": {
"@cucumber/message-streams": "^3.0.0",
"@cucumber/messages": "^17.1.1"
},
"directories": {
Expand Down
2 changes: 1 addition & 1 deletion json-to-messages/javascript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@cucumber/gherkin-streams": "^5.0.0",
"@cucumber/gherkin-utils": "^7.0.0",
"@cucumber/messages": "^17.1.1",
"@cucumber/message-streams": "^3.0.0",
"@cucumber/message-streams": "^4.0.0",
"commander": "9.1.0",
"glob": "7.2.0",
"source-map-support": "0.5.21"
Expand Down
1 change: 0 additions & 1 deletion message-streams/.rsync

This file was deleted.

54 changes: 0 additions & 54 deletions message-streams/CHANGELOG.md

This file was deleted.

2 changes: 0 additions & 2 deletions message-streams/Makefile

This file was deleted.

4 changes: 0 additions & 4 deletions message-streams/README.md

This file was deleted.

89 changes: 0 additions & 89 deletions message-streams/default.mk

This file was deleted.

19 changes: 0 additions & 19 deletions message-streams/javascript/.gitignore

This file was deleted.

6 changes: 0 additions & 6 deletions message-streams/javascript/.mocharc.json

This file was deleted.

1 change: 0 additions & 1 deletion message-streams/javascript/.rsync

This file was deleted.

1 change: 0 additions & 1 deletion message-streams/javascript/Makefile

This file was deleted.

4 changes: 0 additions & 4 deletions message-streams/javascript/README.md

This file was deleted.

87 changes: 0 additions & 87 deletions message-streams/javascript/default.mk

This file was deleted.

3 changes: 0 additions & 3 deletions message-streams/javascript/package.cjs.json

This file was deleted.

Loading