-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle retry in html formatter #1631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change to messages, so don't forget a changelog entry there.
Great PR!!
compatibility-kit/javascript/features/data-tables/data-tables.feature.ndjson
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
@aslakhellesoy you okay with this one now? |
Details
fake-cucumber
about retrycompatibility-kit
feature for retryquery
the smarts to get results from the latest attempt onlywillBeRetried
toTestCaseFinished
json-formatter
?No React components actually need updating.
Motivation and Context
Fixes #1533, #902.
Our Ruby and JavaScript implementations support retry, but the HTML formatter and related tooling don't handle retried test cases at the moment.
This changes
query
(and thus the React components) to treat the last attempt that ran for any given test case as the "canonical" result. This is consistent with the Cucumber implementations' own reporting with builtin formatters.Also an opportunity to resolve #902 (and thus cucumber/cucumber-js#1409) before any consumers start using that misplaced field.
Types of changes
messages
only) (fix or feature that would cause existing functionality to not work as expected).Checklist: