Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: include willBeRetried in after hook argument #2045

Merged
merged 5 commits into from
Jun 6, 2022

Conversation

davidjgoss
Copy link
Contributor

🤔 What's changed?

Add willBeRetried to the argument passed to After hooks.

⚡️ What's your motivation?

See #2010. Previously this existed on the result message for the test step, but the field was pulled up to test case level in cucumber/common#1631. The info is still useful for consumers.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title include willBeRetried in after hook argument support: include willBeRetried in after hook argument May 30, 2022
@coveralls
Copy link

coveralls commented May 30, 2022

Coverage Status

Coverage increased (+0.001%) to 98.331% when pulling 0044fc0 on restore-willberetried-after-hook into 535589c on main.

@davidjgoss davidjgoss merged commit 126772d into main Jun 6, 2022
@davidjgoss davidjgoss deleted the restore-willberetried-after-hook branch June 6, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants