Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Groovy: Allow tests to run multi-threaded in the same JVM (easy fix) #723

Closed
bradleyhart opened this issue Jun 3, 2014 · 2 comments
Closed

Groovy: Allow tests to run multi-threaded in the same JVM (easy fix) #723

bradleyhart opened this issue Jun 3, 2014 · 2 comments

Comments

@bradleyhart
Copy link

The GroovyBackend class has a static variable and this causes problems when running tests in parallel in the same JVM. I have branched the code myself and fixed it by making the "instance" in GroovyBackend a ThreadLocal and this seemed to work a treat. Please could you change it to a ThreadLocal so that I can use the main branch of Cucumber instead of my fork. If it is easier I could submit a pull request, but the change is so simple I am not sure it is needed.

Thanks
Brad
@aslakhellesoy
Copy link
Contributor

Please submit a pull request :-)

bradleyhart pushed a commit to bradleyhart/cucumber-jvm that referenced this issue Jun 9, 2014
Fixing issue cucumber#723. Made the Groovy backend instance a thread …
6fbe602 
…local so that tests can run in parallel in the same JVM
@aslakhellesoy aslakhellesoy mentioned this issue Jun 26, 2014
Merged
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aslakhellesoy @bradleyhart