Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groovy-Cucumber: support more then one World {} definition #716

Merged
merged 3 commits into from
Jun 26, 2014

Conversation

Luxor
Copy link
Contributor

@Luxor Luxor commented May 9, 2014

Enable ablity to use more then one World definition for Groovy Cucumber. E.g, a World for each step definition

Related to #458

@Luxor Luxor changed the title Groovy-Cucumber: support multiple World's Groovy-Cucumber: support more then one World {} definition May 30, 2014
@aslakhellesoy
Copy link
Contributor

This looks great! I recently integrated #723, which causes some of the tests in this PR to break. Could you fix that please?

Also, I'd really prefer to keep unit tests in Java rather than Groovy. I don't think moving GroovyBackendTest to Groovy is necessary for this change.

Finally, please follow coding conventions. See CONTRIBUTING.md. In particular: No wildcard imports.

@Luxor
Copy link
Contributor Author

Luxor commented Jun 26, 2014

Ok, will take a look today

@Luxor
Copy link
Contributor Author

Luxor commented Jun 26, 2014

Done

@aslakhellesoy aslakhellesoy merged commit 5b29856 into cucumber:master Jun 26, 2014
aslakhellesoy added a commit that referenced this pull request Jun 26, 2014
nhajratw pushed a commit to nhajratw/cucumber-jvm that referenced this pull request Jun 27, 2014
Luxor pushed a commit to Luxor/cucumber-jvm that referenced this pull request Jun 30, 2014
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants